diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java index 2cbce5612073c..b30190be341c8 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/PersistentTopicsTest.java @@ -92,6 +92,7 @@ import org.apache.zookeeper.KeeperException; import org.awaitility.Awaitility; import org.mockito.ArgumentCaptor; +import org.mockito.internal.util.MockUtil; import org.testng.Assert; import org.testng.annotations.AfterMethod; import org.testng.annotations.BeforeClass; @@ -99,7 +100,7 @@ import org.testng.annotations.Test; @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-admin") public class PersistentTopicsTest extends MockedPulsarServiceBaseTest { private PersistentTopics persistentTopics; @@ -1501,6 +1502,8 @@ public void testDeleteTopic() throws Exception { verify(response, timeout(5000).times(1)).resume(responseCaptor.capture()); Assert.assertEquals(responseCaptor.getValue().getStatus(), Response.Status.NO_CONTENT.getStatusCode()); + MockUtil.resetMock(brokerService); + CompletableFuture deleteTopicFuture2 = new CompletableFuture<>(); ArgumentCaptor errorCaptor = ArgumentCaptor.forClass(RestException.class); deleteTopicFuture2.completeExceptionally(new MetadataStoreException("test exception")); @@ -1511,6 +1514,8 @@ public void testDeleteTopic() throws Exception { Assert.assertEquals(errorCaptor.getValue().getResponse().getStatus(), Response.Status.INTERNAL_SERVER_ERROR.getStatusCode()); + MockUtil.resetMock(brokerService); + CompletableFuture deleteTopicFuture3 = new CompletableFuture<>(); response = mock(AsyncResponse.class); deleteTopicFuture3.completeExceptionally(new MetadataStoreException.NotFoundException()); diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicMessageTTLTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicMessageTTLTest.java index 8740ff384ddab..dce07218ee150 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicMessageTTLTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/TopicMessageTTLTest.java @@ -36,7 +36,7 @@ import org.testng.annotations.Test; @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-admin") public class TopicMessageTTLTest extends MockedPulsarServiceBaseTest { private final String testTenant = "my-tenant"; diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthLogsTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthLogsTest.java index d33e21cc27ed0..6ffcecbeb9f8b 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthLogsTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthLogsTest.java @@ -41,7 +41,7 @@ * However it is useful to see which logs are produced when there's an * failure or error in authentication. */ -@Test(groups = "flaky") +@Test(groups = "broker") public class AuthLogsTest extends MockedPulsarServiceBaseTest { private static final Logger log = LoggerFactory.getLogger(AuthLogsTest.class); diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthorizationTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthorizationTest.java index 76720f4ecaa3b..11afe889ee935 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthorizationTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/auth/AuthorizationTest.java @@ -38,7 +38,7 @@ import org.testng.annotations.BeforeClass; import org.testng.annotations.Test; -@Test(groups = "flaky") +@Test(groups = "broker") public class AuthorizationTest extends MockedPulsarServiceBaseTest { public AuthorizationTest() { diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java index edc67263d891e..8b4fe085407ed 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java @@ -45,7 +45,7 @@ import org.testng.annotations.BeforeMethod; import org.testng.annotations.Test; -@Test(groups = "flaky") +@Test(groups = "broker") public class InactiveTopicDeleteTest extends BrokerTestBase { @BeforeMethod diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java index 4d94c00130571..c23b23d0ed2e3 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ServerCnxTest.java @@ -141,7 +141,7 @@ import org.testng.annotations.Test; @SuppressWarnings("unchecked") -@Test(groups = "flaky") +@Test(groups = "broker") public class ServerCnxTest { protected EmbeddedChannel channel; private ServiceConfiguration svcConfig; diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationTest.java index ae699b7db8271..168886f733a3c 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationTest.java @@ -23,7 +23,6 @@ import static org.testng.Assert.assertNotNull; import static org.testng.Assert.assertNull; import static org.testng.Assert.assertTrue; - import java.util.ArrayList; import java.util.Arrays; import java.util.List; @@ -41,7 +40,7 @@ import org.testng.annotations.Test; @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-api") public class ClientDeduplicationTest extends ProducerConsumerBase { @DataProvider diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java index 1602f0162d470..a41aac9bd457f 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/MultiTopicsReaderTest.java @@ -66,7 +66,7 @@ import org.testng.annotations.Test; @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-impl") public class MultiTopicsReaderTest extends MockedPulsarServiceBaseTest { private static final String subscription = "reader-multi-topics-sub"; diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java index 408885d35cfda..fb09cd9951885 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/RawReaderTest.java @@ -49,7 +49,7 @@ import org.testng.annotations.BeforeMethod; import org.testng.annotations.Test; -@Test(groups = "flaky") +@Test(groups = "broker-impl") public class RawReaderTest extends MockedPulsarServiceBaseTest { private static final String subscription = "foobar-sub"; diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java index 20779003fb143..af18c2ed5c173 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java @@ -27,21 +27,21 @@ import static org.testng.Assert.assertNull; import static org.testng.Assert.assertTrue; import static org.testng.Assert.fail; +import io.netty.channel.ChannelHandlerContext; +import io.netty.util.concurrent.EventExecutor; import java.lang.reflect.Constructor; import java.lang.reflect.Field; +import java.util.ArrayList; import java.util.Collection; +import java.util.List; import java.util.Optional; import java.util.Set; import java.util.TreeSet; import java.util.concurrent.CompletableFuture; -import java.util.ArrayList; -import java.util.List; import java.util.concurrent.CountDownLatch; import java.util.concurrent.ExecutionException; import java.util.concurrent.TimeUnit; import java.util.concurrent.atomic.AtomicReference; -import io.netty.channel.ChannelHandlerContext; -import io.netty.util.concurrent.EventExecutor; import lombok.Cleanup; import lombok.extern.slf4j.Slf4j; import org.apache.bookkeeper.mledger.Position; @@ -89,7 +89,7 @@ * End to end transaction test. */ @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-impl") public class TransactionEndToEndTest extends TransactionTestBase { protected static final int TOPIC_PARTITION = 3; diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java index 36afd33da0cb3..52faae2f8ea1f 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndWithoutBatchIndexAckTest.java @@ -27,7 +27,7 @@ * End to end transaction test. */ @Slf4j -@Test(groups = "flaky") +@Test(groups = "broker-impl") public class TransactionEndToEndWithoutBatchIndexAckTest extends TransactionEndToEndTest { @BeforeClass diff --git a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java index 5df7e094c93e3..681b4a39c8e25 100644 --- a/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java +++ b/pulsar-broker/src/test/java/org/apache/pulsar/compaction/CompactionTest.java @@ -22,12 +22,13 @@ import static org.mockito.Mockito.spy; import static org.mockito.Mockito.when; import static org.testng.Assert.assertEquals; +import static org.testng.Assert.assertFalse; import static org.testng.Assert.assertNotNull; import static org.testng.Assert.assertNull; import static org.testng.Assert.assertTrue; -import static org.testng.Assert.assertFalse; import com.google.common.collect.Sets; import com.google.common.util.concurrent.ThreadFactoryBuilder; +import io.netty.buffer.ByteBuf; import java.io.IOException; import java.nio.charset.StandardCharsets; import java.nio.file.Files; @@ -45,7 +46,6 @@ import java.util.concurrent.Executors; import java.util.concurrent.ScheduledExecutorService; import java.util.concurrent.TimeUnit; -import io.netty.buffer.ByteBuf; import lombok.Cleanup; import lombok.SneakyThrows; import org.apache.bookkeeper.client.BookKeeper; @@ -90,7 +90,7 @@ import org.testng.annotations.DataProvider; import org.testng.annotations.Test; -@Test(groups = "flaky") +@Test(groups = "broker-impl") public class CompactionTest extends MockedPulsarServiceBaseTest { private ScheduledExecutorService compactionScheduler; private BookKeeper bk;