Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Env Variable Fixes #3520

Merged
merged 3 commits into from Feb 17, 2020
Merged

Env Variable Fixes #3520

merged 3 commits into from Feb 17, 2020

Conversation

SaraVieira
Copy link
Contributor

Fixes:

  1. Server secret: button should be disabled without values + clicking button doesnt send @sara Vieira
  2. Server secret: Space between description and keys should be 16px @sara Vieira
  3. Live doesn't show reconnecting status. @sara Vieira

@lbogdan lbogdan temporarily deployed to pr3520 February 14, 2020 12:24 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Feb 14, 2020 •
edited

Build for latest commit 1ed3ae5 is at https://pr3520.build.csb.dev/s/new.

@lbogdan lbogdan temporarily deployed to pr3520 February 14, 2020 12:40 Inactive
siddharthkp
siddharthkp approved these changes Feb 17, 2020
View reviewed changes
Copy link
Contributor

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very nicely! Good job!

@siddharthkp siddharthkp merged commit a0e94b4 into master Feb 17, 2020
@siddharthkp siddharthkp deleted the env-fixes branch February 17, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees
No one assigned
Labels
UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SaraVieira @lbogdan @siddharthkp @MichaelDeBoey