POC: Sandpack Service Worker to Resolve Relative Files #5137
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90cf747:
|
|
Build for latest commit 90cf747 is at https://pr5137.build.csb.dev/s/new. |
souldzin
force-pushed the
souldzin:ps-sandpack-service-worker-poc
branch
from
18910fb
to
60c647a
- This needs to be built and tagged to prevent the eager caching of service workers in browsers.
souldzin
force-pushed the
souldzin:ps-sandpack-service-worker-poc
branch
from
60c647a
to
9321ae6
- Passes request / response info through client/window message API. - Has the fallback ability to passthrough a request with default behavior when client can't resolve it.
souldzin
force-pushed the
souldzin:ps-sandpack-service-worker-poc
branch
from
ead2d35
to
c4ccce6
This is important for the sandpack service worker to have the right `contentType` in the response. This is only used by the new sandpack service worker.
souldzin
force-pushed the
souldzin:ps-sandpack-service-worker-poc
branch
from
c4ccce6
to
90cf747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DO NOTE MERGE!
This PR is just the POC for setting up the Sandpack package to use a Service Worker for resolving relative files. This will be refined and broken into smaller MR's for iteration + ease of review.
Context
Check out the relevant:
Does it work?
Here's the latest integration demo of this working with self-hosted Codesandbox assets and the GitLab Web IDE
cc @CompuIves