New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Sandpack Service Worker to Resolve Relative Files #5137
POC: Sandpack Service Worker to Resolve Relative Files #5137
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 90cf747:
|
|
Build for latest commit 90cf747 is at https://pr5137.build.csb.dev/s/new. |
18910fb
to
60c647a
Compare
- This needs to be built and tagged to prevent the eager caching of service workers in browsers.
60c647a
to
9321ae6
Compare
- Passes request / response info through client/window message API. - Has the fallback ability to passthrough a request with default behavior when client can't resolve it.
ead2d35
to
c4ccce6
Compare
This is important for the sandpack service worker to have the right `contentType` in the response. This is only used by the new sandpack service worker.
c4ccce6
to
90cf747
Compare
|
This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed. |
|
This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed. |
|
This PR has been automatically closed because there wasn't any activity after the previous notice or the stale label wasn't removed. |
DO NOTE MERGE!
This PR is just the POC for setting up the Sandpack package to use a Service Worker for resolving relative files. This will be refined and broken into smaller MR's for iteration + ease of review.
Context
Check out the relevant:
Does it work?
Here's the latest integration demo of this working with self-hosted Codesandbox assets and the GitLab Web IDE
cc @CompuIves