Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC: Sandpack Service Worker to Resolve Relative Files #5137

Closed

Conversation

souldzin
Copy link
Contributor

@souldzin souldzin commented Nov 16, 2020

DO NOTE MERGE!

This PR is just the POC for setting up the Sandpack package to use a Service Worker for resolving relative files. This will be refined and broken into smaller MR's for iteration + ease of review.

Context

Check out the relevant:

Does it work?

Here's the latest integration demo of this working with self-hosted Codesandbox assets and the GitLab Web IDE

cc @CompuIves

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 90cf747:

Sandbox Source
Notifications Test Configuration

@lbogdan lbogdan temporarily deployed to pr5137 November 16, 2020 18:42 Inactive
@lbogdan
Copy link
Contributor

lbogdan commented Nov 16, 2020

Build for latest commit 90cf747 is at https://pr5137.build.csb.dev/s/new.

- This needs to be built and tagged to prevent the
eager caching of service workers in browsers.
@souldzin souldzin force-pushed the ps-sandpack-service-worker-poc branch from 60c647a to 9321ae6 Compare December 14, 2020 00:12
@lbogdan lbogdan temporarily deployed to pr5137 December 14, 2020 00:23 Inactive
@lbogdan lbogdan temporarily deployed to pr5137 December 17, 2020 04:01 Inactive
- Passes request / response info through client/window message API.
- Has the fallback ability to passthrough a request with default
  behavior when client can't resolve it.
@souldzin souldzin force-pushed the ps-sandpack-service-worker-poc branch from ead2d35 to c4ccce6 Compare December 17, 2020 04:03
@lbogdan lbogdan temporarily deployed to pr5137 December 17, 2020 04:09 Inactive
This is important for the sandpack service worker to have
the right `contentType` in the response.

This is only used by the new sandpack service worker.
@github-actions
Copy link

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

@github-actions github-actions bot added the stale label Mar 18, 2021
@CompuIves CompuIves removed the stale label Mar 29, 2021
@github-actions
Copy link

This PR has automatically been marked stale because there has been no activity in a while. Please leave a comment if the issue has not been resolved, or if it is not stale for any other reason. After 2 weeks, this issue will automatically be closed, unless a comment is made or the stale label is removed.

@github-actions github-actions bot added the stale label Jun 28, 2021
@github-actions
Copy link

This PR has been automatically closed because there wasn't any activity after the previous notice or the stale label wasn't removed.

@github-actions github-actions bot closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants