[RFC] Shortcuts support for iOS devices

[aadsm]

This is a proof of concept for some of the ideas I suggested on #507.
tl;dr: iOS doesn’t trigger key events just by pressing alt, shift, etc.

The solution I’m proposing to fix this comes with pros/cons:

Pros:

• The ability to have shortcuts on iOS 😎.

Cons:

• Can only use Alt and Shift as key modifiers.
• Not able anymore to use the keys generated by one of the shortcuts (e.g.: Alt+Shift+P prints ∏ on my keyboard) [I have another workaround in mind to solve this though].

[CompuIves]

I love this! Great to give iPad users the ability to use keybindings too. Is this ready to merge in?

[aadsm]

Cool, glad you like it. Not yet, there’s at least one thing missing (I can get to this on the weekend): * Support for sequenced/secondary shorcuts (easly doable, just wanted to get out a proof of concept first). These could be follow up items: * Default to CodeMirror on iOS (and a warning on this preference about only CM working on iOS). * The ability to disable these shortcuts since they highjack a keystroke that otherwise would print a character. I was thinking about toggling it by pressing Alt-Backspace (the only one I found that doesn’t print a character). * I believe I saw sequence bindings defined like “Shift”, “Cmd”. These would never trigger on iOS so a different one would need to be set for them.

On Wed, Apr 25, 2018 at 02:38 Ives van Hoorne ***@***.***> wrote: I love this! Great to give iPad users the ability to use keybindings too. Is this ready to merge in? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#749 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAExKpqMuLuX-VDiOG3XwT-Gj4Y65gaXks5tsEP5gaJpZM4TfEqV> .

-- Best regards, António Afonso

[aadsm]

@CompuIves, I’ve updated the PR with better code to implement secondary bindings. I’ve also “fixed“ an assumption that existed in the code about the keyCode. It was doing String.fromCharCode(keyCode) but the keyCode is not a charCode 😛 (you gotta love the key event api). Anyway, check the comment I wrote there as I explain a bit better what’s going on.

I haven’t had the time yet to look into the monoco/vscode implementation like we discussed, but this PR is good enough that will give some type of support to iOS users, specially iPad with keyboard. So I’ll support merging it and then solve the rest of the issues later.
For the record, what is missing right now is handling shortcuts that are handled by CodeMirror (e.g.: Alt-K), and also secondary bindings.

[CompuIves]

I love the clear implementation and the comments. Thank you so much for the work and effort in this PR! I'll merge this in now, everything looks good to me!