Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error screen details and small fixes #36

Merged
merged 3 commits into from
Mar 30, 2021
Merged

error screen details and small fixes #36

merged 3 commits into from
Mar 30, 2021

Conversation

alexnm
Copy link
Collaborator

@alexnm alexnm commented Mar 30, 2021

closes #32 - head tag replacing the original html head in the bundler on the first load
closes #14 - more information shown on runtime errors
closes #15 - option set to false in sandpack-client, can later be overwritten
closes #16 - inside the bundler

@alexnm alexnm requested a review from CompuIves March 30, 2021 14:59
Copy link
Member

@danilowoz danilowoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't know much about the architecture decision, but the code is very clear and looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants