Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append heroku application name in packaging #258

Merged
merged 1 commit into from Mar 20, 2019

Conversation

@davidkwan95
Copy link
Contributor

davidkwan95 commented Mar 20, 2019

Issue: running the scripts in parallel for different apps make deployment to heroku fail. Problem occurs because of race condition I assume.
Solution: append heroku app name to artifact path so each app deployment has different package that doesn't interfere with each other

@joesiewert joesiewert self-requested a review Mar 20, 2019
@joesiewert joesiewert merged commit 3fd29b8 into codeship:master Mar 20, 2019
1 check passed
1 check passed
continuous-integration/codeship Build succeeded
Details
@joesiewert

This comment has been minimized.

Copy link
Member

joesiewert commented Mar 20, 2019

Great, thanks @davidkwan95!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.