perf(vectorindex): zero-copy GetVector/GetVectorRef via unsafe.Slice on mmap#58
Merged
Conversation
Replace per-element binary.LittleEndian.Uint32 deserialization (128 iterations) with a single unsafe.Slice + copy for GetVector, and true zero-copy return for GetVectorRef (caller must not retain past grow/remap). Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
…p reference GetVectorRef previously returned an unsafe.Slice directly into the mmap region, which could become invalid after grow/remap. Delegate to GetVector which already does unsafe.Slice + copy, eliminating the safety hazard while retaining the binary-read performance benefit over binary.Uint32 decoding. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
Verify the mmap offset is 4-byte aligned before casting to *float32 via unsafe.Pointer. The layout guarantees alignment (pageSize=4096 header, dim*4 slot size), but an explicit check prevents silent UB if the format ever changes. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
The mmap store reads float32/uint32/uint64 directly from mapped memory assuming LE byte order. Add an init() panic guard so builds on BE platforms fail fast instead of silently returning corrupt data. Co-Authored-By: Claude Opus 4 (1M context) <noreply@anthropic.com>
codetrek
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MmapStore GetVector 零拷贝优化
改动
50K SIFT-128 Benchmark
搜索延迟提升 2.5x。