Repo#find_by_full_name triggers memory bloat w/ :issues include #469

Merged
merged 1 commit into from May 17, 2016

Projects

None yet

3 participants

@itsderek23
Contributor

It appears that Repo#find_by_full_name triggers some memory bloat when called by repos with many issues:

reposcontroller_show

I believe the offender is the includes(:issues), which thankfully, I don't believe is used by any of the callers.

Here's a massive one-line PR to address this.

@prathamesh-sonpatki

Nice catch!

@prathamesh-sonpatki prathamesh-sonpatki merged commit ce22f94 into codetriage:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schneems
Member

You found it! Great job.

Did you see the commit that introduced that line itsderek23@9543d90 😉

@itsderek23
Contributor

image

CodeTriage: our codez are so good, we make our own bugs.

@schneems
Member

The bug was in production for a good 6 months-ish, which is how long it took me to track down. I re-introduced it to play with some other debugging tools. None have found them as quickly or accurately as Scout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment