New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo#find_by_full_name triggers memory bloat w/ :issues include #469

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
3 participants
@itsderek23
Contributor

itsderek23 commented May 16, 2016

It appears that Repo#find_by_full_name triggers some memory bloat when called by repos with many issues:

reposcontroller_show

I believe the offender is the includes(:issues), which thankfully, I don't believe is used by any of the callers.

Here's a massive one-line PR to address this.

@prathamesh-sonpatki

This comment has been minimized.

Show comment
Hide comment
@prathamesh-sonpatki

prathamesh-sonpatki May 17, 2016

Member

Nice catch!

Nice catch!

@prathamesh-sonpatki prathamesh-sonpatki merged commit ce22f94 into codetriage:master May 17, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems May 17, 2016

Member

You found it! Great job.

Did you see the commit that introduced that line itsderek23@9543d90 😉

Member

schneems commented May 17, 2016

You found it! Great job.

Did you see the commit that introduced that line itsderek23@9543d90 😉

@itsderek23

This comment has been minimized.

Show comment
Hide comment
@itsderek23

itsderek23 May 17, 2016

Contributor

image

CodeTriage: our codez are so good, we make our own bugs.

Contributor

itsderek23 commented May 17, 2016

image

CodeTriage: our codez are so good, we make our own bugs.

@schneems

This comment has been minimized.

Show comment
Hide comment
@schneems

schneems May 17, 2016

Member

The bug was in production for a good 6 months-ish, which is how long it took me to track down. I re-introduced it to play with some other debugging tools. None have found them as quickly or accurately as Scout.

Member

schneems commented May 17, 2016

The bug was in production for a good 6 months-ish, which is how long it took me to track down. I re-introduced it to play with some other debugging tools. None have found them as quickly or accurately as Scout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment