Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upEnsure select text colour is black #495
Conversation
gizotti
added some commits
Jul 19, 2016
This comment has been minimized.
This comment has been minimized.
Thanks, no clue why builds are failing, but i'm pretty sure it's not due to this PR. |
schneems
merged commit ffff4e0
into
codetriage:master
Jul 20, 2016
1 check failed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
This comment has been minimized.
This comment has been minimized.
No worries, I made sure I ran it in my local env and all passed, so I guess it was just a hiccup hey. |
prathamesh-sonpatki
referenced this pull request
Dec 18, 2016
Closed
Unselected values difficult to read in "Triage More" selector #432
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
gizotti commentedJul 19, 2016
•
edited
This PR adds a css styling across all select boxes to ensure black text colour.
With this PR issue #494 can be closed, and I believe #432 as well.
Select value already defaults to "daily", as mentioned on #494, so nothing else had to be done.