New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the description meta tag #702

Merged
merged 1 commit into from Apr 11, 2018

Conversation

Projects
None yet
3 participants
@vaidehijoshi
Contributor

vaidehijoshi commented Apr 10, 2018

Before this change, we were doing two queries per request to get the count of users and repos to generate the description meta tag (see screenshot below). Presumably, we don't actually care that these numbers are super up-to-date, so we can cache it up to an hour (same as the similar text in the template's h2 tag).

screen shot 2018-04-10 at 4 13 20 pm

Cache the description meta tag
Before this change, we were doing two queries per request to get the
count of users and repos to generate the description meta tag.
Presumably, we don't actually care that these numbers are super
up-to-date, so we can cache it up to an hour (same as the similar text
in the template's h2 tag).

@prathamesh-sonpatki prathamesh-sonpatki self-requested a review Apr 11, 2018

@schneems

This comment has been minimized.

Member

schneems commented Apr 11, 2018

Great job, thanks!

@schneems schneems merged commit 2338feb into codetriage:master Apr 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@vaidehijoshi vaidehijoshi deleted the tildeio:cache-meta-description branch Apr 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment