From c3f2a64dc8e73801d62481fafe45c6e48c071532 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:26:30 +0100 Subject: [PATCH 01/43] add initial example workflow --- .github/workflows/run-tests.yml | 18 ++++++++++++++++++ yarn.lock | 19 +++++-------------- 2 files changed, 23 insertions(+), 14 deletions(-) create mode 100644 .github/workflows/run-tests.yml diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 0000000..15a61d6 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,18 @@ +name: GitHub Actions Demo +run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 +on: [push] +jobs: + Explore-GitHub-Actions: + runs-on: ubuntu-latest + steps: + - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event." + - run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!" + - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}." + - name: Check out repository code + uses: actions/checkout@v4 + - run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner." + - run: echo "🖥️ The workflow is now ready to test your code on the runner." + - name: List files in the repository + run: | + ls ${{ github.workspace }} + - run: echo "🍏 This job's status is ${{ job.status }}." diff --git a/yarn.lock b/yarn.lock index b0a58f4..de2b62c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8426,7 +8426,7 @@ resolved "https://registry.yarnpkg.com/@types/range-parser/-/range-parser-1.2.7.tgz#50ae4353eaaddc04044279812f52c8c65857dbcb" integrity sha512-hKormJbkJqzQGhziax5PItDUTMAM9uE2XXQmM37dyd4hVM+5aVl7oVxMVUiVQn2oCQFN/LKCZdvSM0pFRqbSmQ== -"@types/react-dom@*", "@types/react-dom@^18.0.0": +"@types/react-dom@*", "@types/react-dom@^18", "@types/react-dom@^18.0.0": version "18.2.19" resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.2.19.tgz#b84b7c30c635a6c26c6a6dfbb599b2da9788be58" integrity sha512-aZvQL6uUbIJpjZk4U8JZGbau9KDeAwMfmhyWorxgBkqDIEf6ROjRozcmPIicqsUwPUjbkDfHKgGee1Lq65APcA== @@ -8464,19 +8464,10 @@ dependencies: "@types/react" "*" -"@types/react@*": - version "18.2.55" - resolved "https://registry.yarnpkg.com/@types/react/-/react-18.2.55.tgz#38141821b7084404b5013742bc4ae08e44da7a67" - integrity sha512-Y2Tz5P4yz23brwm2d7jNon39qoAtMMmalOQv6+fEFt1mT+FcM3D841wDpoUvFXhaYenuROCy3FZYqdTjM7qVyA== - dependencies: - "@types/prop-types" "*" - "@types/scheduler" "*" - csstype "^3.0.2" - -"@types/react@^16.13.1 || ^17.0.0": - version "17.0.75" - resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.75.tgz#cffbc76840a12fcadaf5a3cf14878bb06efcf73d" - integrity sha512-MSA+NzEzXnQKrqpO63CYqNstFjsESgvJAdAyyJ1n6ZQq/GLgf6nOfIKwk+Twuz0L1N6xPe+qz5xRCJrbhMaLsw== +"@types/react@*", "@types/react@^16.13.1 || ^17.0.0", "@types/react@^18": + version "18.2.57" + resolved "https://registry.yarnpkg.com/@types/react/-/react-18.2.57.tgz#147b516d8bdb2900219acbfc6f939bdeecca7691" + integrity sha512-ZvQsktJgSYrQiMirAN60y4O/LRevIV8hUzSOSNB6gfR3/o3wCBFQx3sPwIYtuDMeiVgsSS3UzCV26tEzgnfvQw== dependencies: "@types/prop-types" "*" "@types/scheduler" "*" From f2a70b0ddd961d63d1eb383709609fd6c57c460c Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:30:07 +0100 Subject: [PATCH 02/43] update testing steps to yarn test --- .github/workflows/run-tests.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 15a61d6..3650a82 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -5,14 +5,4 @@ jobs: Explore-GitHub-Actions: runs-on: ubuntu-latest steps: - - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event." - - run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!" - - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}." - - name: Check out repository code - uses: actions/checkout@v4 - - run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner." - - run: echo "🖥️ The workflow is now ready to test your code on the runner." - - name: List files in the repository - run: | - ls ${{ github.workspace }} - - run: echo "🍏 This job's status is ${{ job.status }}." + - run: yarn test \ No newline at end of file From 545a87d69be53941a8be457fe9d726aeb7596043 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:48:19 +0100 Subject: [PATCH 03/43] add checkout repo --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 3650a82..1a91e31 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -5,4 +5,5 @@ jobs: Explore-GitHub-Actions: runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - run: yarn test \ No newline at end of file From dad37a728a1eb97d61fbfd71a7fa5cd1e3ca9a60 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:48:43 +0100 Subject: [PATCH 04/43] add setup node js --- .github/workflows/run-tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 1a91e31..fbce1b1 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -6,4 +6,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '20' - run: yarn test \ No newline at end of file From 59dc37e09c2b116d9faf63eef3aa1a0931fa48ba Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:49:50 +0100 Subject: [PATCH 05/43] add yarn install --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index fbce1b1..5d7f072 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -10,4 +10,5 @@ jobs: uses: actions/setup-node@v3 with: node-version: '20' + - run: yarn install - run: yarn test \ No newline at end of file From 253b4e81859cf7805a823ed80e56d8d57c35396a Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:50:17 +0100 Subject: [PATCH 06/43] rename test --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5d7f072..4d2c4f5 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -2,7 +2,7 @@ name: GitHub Actions Demo run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 on: [push] jobs: - Explore-GitHub-Actions: + run-tests: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From be8bf382b25ca1f80a1dcdc2ffa404ab5793b087 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 11:49:26 +0100 Subject: [PATCH 07/43] change test text to correct value --- packages/app/e2e-tests/app.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/e2e-tests/app.test.ts b/packages/app/e2e-tests/app.test.ts index d45bc0d..9807ea2 100644 --- a/packages/app/e2e-tests/app.test.ts +++ b/packages/app/e2e-tests/app.test.ts @@ -19,5 +19,5 @@ import { test, expect } from '@playwright/test'; test('App should render the welcome page', async ({ page }) => { await page.goto('/'); - await expect(page.getByText('My Company Catalog')).toBeVisible(); + await expect(page.getByText('Scaffolded Backstage App')).toBeVisible(); }); From e22c711acfd5b843c0494d88e0a820ac7285497d Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 11:49:43 +0100 Subject: [PATCH 08/43] add end to end tests --- .github/workflows/run-tests.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 4d2c4f5..4c87327 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -11,4 +11,15 @@ jobs: with: node-version: '20' - run: yarn install - - run: yarn test \ No newline at end of file + - run: yarn test + + run-e2e-tests: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '20' + - run: yarn install + - run: yarn playwright test \ No newline at end of file From 53ccce0ba6a3c493125d614418398f1e7e828aa7 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 12:10:09 +0100 Subject: [PATCH 09/43] add playwright url for test env --- .github/workflows/run-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 4c87327..2a6294a 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -14,6 +14,8 @@ jobs: - run: yarn test run-e2e-tests: + env: + PLAYWRIGHT_URL: http:/localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From a1a282e3cde19f8cee41c072049da32a96bab434 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 12:18:37 +0100 Subject: [PATCH 10/43] add install playwright browser --- .github/workflows/run-tests.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 2a6294a..9693c20 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -23,5 +23,9 @@ jobs: uses: actions/setup-node@v3 with: node-version: '20' - - run: yarn install - - run: yarn playwright test \ No newline at end of file + - name: Install dependencies + run: yarn install + - name: Install Playwright Browsers + run: yarn playwright install --with-deps + - name: Run E2E tests + run: yarn playwright test From 582805caf3fc4dd0669bec2cc3cd3fdd35e7fa92 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:14:33 +0100 Subject: [PATCH 11/43] fix: typo in localhost --- .github/workflows/run-tests.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9693c20..0fe9046 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,6 +1,7 @@ name: GitHub Actions Demo run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 on: [push] + jobs: run-tests: runs-on: ubuntu-latest @@ -15,7 +16,7 @@ jobs: run-e2e-tests: env: - PLAYWRIGHT_URL: http:/localhost:3000 + PLAYWRIGHT_URL: http://localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -25,7 +26,7 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - - name: Install Playwright Browsers - run: yarn playwright install --with-deps + # - name: Install Playwright Browsers + # run: yarn playwright install --with-deps - name: Run E2E tests - run: yarn playwright test + run: yarn test:e2e From 580b1289801a753e63ad526b40d6cd01b6c64529 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:21:08 +0100 Subject: [PATCH 12/43] test: add some logging --- .github/workflows/run-tests.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 0fe9046..5435ef0 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -15,8 +15,6 @@ jobs: - run: yarn test run-e2e-tests: - env: - PLAYWRIGHT_URL: http://localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -26,7 +24,14 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - # - name: Install Playwright Browsers - # run: yarn playwright install --with-deps + - name: Install Playwright Browsers + run: yarn playwright install --with-deps - name: Run E2E tests - run: yarn test:e2e + env: + PLAYWRIGHT_URL: http://localhost:3000 + run: | + echo $PLAYWRIGHT_URL + ls + pwd + ls packages + yarn test:e2e From c8a58c32aea27e405681063a52fc7454b6ceced7 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:33:44 +0100 Subject: [PATCH 13/43] test: ci env variable --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5435ef0..300516c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -31,6 +31,7 @@ jobs: PLAYWRIGHT_URL: http://localhost:3000 run: | echo $PLAYWRIGHT_URL + echo $CI ls pwd ls packages From 69c84b7eab8a45161f1e4ac3d872576ecf145cec Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:39:16 +0100 Subject: [PATCH 14/43] fix: make CI env variable empty --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 300516c..93d6e7d 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,6 +29,7 @@ jobs: - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 + CI: run: | echo $PLAYWRIGHT_URL echo $CI From 151f57bedf96b973a0d68b52fd6db7422b45b3f0 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:54:14 +0100 Subject: [PATCH 15/43] fix: unset CI env var, set by default in GithHub Actions --- .github/workflows/run-tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 93d6e7d..7c51103 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,11 +29,6 @@ jobs: - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 - CI: + CI: # unset CI because it is set by default in Github actions run: | - echo $PLAYWRIGHT_URL - echo $CI - ls - pwd - ls packages yarn test:e2e From f947b0884f4fc2a59b5c2e5cc2615dbf795ac8e3 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 16:05:52 +0100 Subject: [PATCH 16/43] try without playwright browser --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 7c51103..237281f 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -24,11 +24,11 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - - name: Install Playwright Browsers - run: yarn playwright install --with-deps + #- name: Install Playwright Browsers + # run: yarn playwright install --with-deps - name: Run E2E tests env: - PLAYWRIGHT_URL: http://localhost:3000 + PLAYWRIGHT_URL: http://localhost:3000 # set the URL of the app to test with playwright CI: # unset CI because it is set by default in Github actions run: | yarn test:e2e From 14881e0eadd731966dbaea870f05046e056ef534 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 28 Feb 2024 13:34:33 +0100 Subject: [PATCH 17/43] add pre commit tests --- package.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package.json b/package.json index 4467ffb..9b19f4c 100644 --- a/package.json +++ b/package.json @@ -24,6 +24,10 @@ "prettier:check": "prettier --check .", "new": "backstage-cli new --scope internal" }, + "pre-commit": [ + "yarn test", + "yarn e2e-test" + ], "workspaces": { "packages": [ "packages/*", @@ -55,4 +59,5 @@ "prettier --write" ] } + } From 2a66977ad29571c488c785d2e60d8046dcc2e0f2 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 28 Feb 2024 13:37:30 +0100 Subject: [PATCH 18/43] this is a test commit --- .github/workflows/run-tests.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 237281f..062d7e8 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,7 +1,8 @@ -name: GitHub Actions Demo -run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 -on: [push] +name: Test and E2E tests +run-name: Run tests and E2E tests +on: [push] +test jobs: run-tests: runs-on: ubuntu-latest @@ -17,12 +18,12 @@ jobs: run-e2e-tests: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v4 #chekcout te repository - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v3 #setup node version 20 with: node-version: '20' - - name: Install dependencies + - name: Install dependencies #install dependencies run: yarn install #- name: Install Playwright Browsers # run: yarn playwright install --with-deps From 920f3dd5305d6788bd8367865449569c8d1e415a Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 17:05:01 +0100 Subject: [PATCH 19/43] change test comand --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 9b19f4c..d458826 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "tsc": "tsc", "tsc:full": "tsc --skipLibCheck false --incremental false", "clean": "backstage-cli repo clean", - "test": "backstage-cli repo test", + "test": "backstage-cli repo test && playwright test", "test:all": "backstage-cli repo test --coverage", "test:e2e": "playwright test", "fix": "backstage-cli repo fix", From c7117b751f2aaf4701d94d92a228a4b80628b71f Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 17:05:13 +0100 Subject: [PATCH 20/43] change when test runs --- .github/workflows/run-tests.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 062d7e8..8caea7f 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,8 +1,11 @@ name: Test and E2E tests run-name: Run tests and E2E tests -on: [push] -test +on: + push: + pull_request: + branches: + - main jobs: run-tests: runs-on: ubuntu-latest @@ -23,10 +26,10 @@ jobs: uses: actions/setup-node@v3 #setup node version 20 with: node-version: '20' + - name: Install dependencies #install dependencies run: yarn install - #- name: Install Playwright Browsers - # run: yarn playwright install --with-deps + - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 # set the URL of the app to test with playwright From 9f6e54b2d8addaddc4402ac48f7c59a17a969102 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:26:30 +0100 Subject: [PATCH 21/43] add initial example workflow --- .github/workflows/run-tests.yml | 18 ++++++++++++++++++ yarn.lock | 11 +---------- 2 files changed, 19 insertions(+), 10 deletions(-) create mode 100644 .github/workflows/run-tests.yml diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml new file mode 100644 index 0000000..15a61d6 --- /dev/null +++ b/.github/workflows/run-tests.yml @@ -0,0 +1,18 @@ +name: GitHub Actions Demo +run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 +on: [push] +jobs: + Explore-GitHub-Actions: + runs-on: ubuntu-latest + steps: + - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event." + - run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!" + - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}." + - name: Check out repository code + uses: actions/checkout@v4 + - run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner." + - run: echo "🖥️ The workflow is now ready to test your code on the runner." + - name: List files in the repository + run: | + ls ${{ github.workspace }} + - run: echo "🍏 This job's status is ${{ job.status }}." diff --git a/yarn.lock b/yarn.lock index 8ec8567..5e48406 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8915,7 +8915,7 @@ resolved "https://registry.yarnpkg.com/@types/range-parser/-/range-parser-1.2.7.tgz#50ae4353eaaddc04044279812f52c8c65857dbcb" integrity sha512-hKormJbkJqzQGhziax5PItDUTMAM9uE2XXQmM37dyd4hVM+5aVl7oVxMVUiVQn2oCQFN/LKCZdvSM0pFRqbSmQ== -"@types/react-dom@*", "@types/react-dom@^18.0.0": +"@types/react-dom@*", "@types/react-dom@^18", "@types/react-dom@^18.0.0": version "18.2.19" resolved "https://registry.yarnpkg.com/@types/react-dom/-/react-dom-18.2.19.tgz#b84b7c30c635a6c26c6a6dfbb599b2da9788be58" integrity sha512-aZvQL6uUbIJpjZk4U8JZGbau9KDeAwMfmhyWorxgBkqDIEf6ROjRozcmPIicqsUwPUjbkDfHKgGee1Lq65APcA== @@ -8953,15 +8953,6 @@ dependencies: "@types/react" "*" -"@types/react@*", "@types/react@^16.13.1 || ^17.0.0 || ^18.0.0": - version "18.2.56" - resolved "https://registry.yarnpkg.com/@types/react/-/react-18.2.56.tgz#2d3e9021a0b6eb5bfc227761cc61b1c6dc6e0cd8" - integrity sha512-NpwHDMkS/EFZF2dONFQHgkPRwhvgq/OAvIaGQzxGSBmaeR++kTg6njr15Vatz0/2VcCEwJQFi6Jf4Q0qBu0rLA== - dependencies: - "@types/prop-types" "*" - "@types/scheduler" "*" - csstype "^3.0.2" - "@types/react@^16.13.1 || ^17.0.0": version "17.0.75" resolved "https://registry.yarnpkg.com/@types/react/-/react-17.0.75.tgz#cffbc76840a12fcadaf5a3cf14878bb06efcf73d" From 7f953ba47da0aa6eacbbcbcf63ce2c54dda44394 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:30:07 +0100 Subject: [PATCH 22/43] update testing steps to yarn test --- .github/workflows/run-tests.yml | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 15a61d6..3650a82 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -5,14 +5,4 @@ jobs: Explore-GitHub-Actions: runs-on: ubuntu-latest steps: - - run: echo "🎉 The job was automatically triggered by a ${{ github.event_name }} event." - - run: echo "🐧 This job is now running on a ${{ runner.os }} server hosted by GitHub!" - - run: echo "🔎 The name of your branch is ${{ github.ref }} and your repository is ${{ github.repository }}." - - name: Check out repository code - uses: actions/checkout@v4 - - run: echo "💡 The ${{ github.repository }} repository has been cloned to the runner." - - run: echo "🖥️ The workflow is now ready to test your code on the runner." - - name: List files in the repository - run: | - ls ${{ github.workspace }} - - run: echo "🍏 This job's status is ${{ job.status }}." + - run: yarn test \ No newline at end of file From 32bdb74224a8a37eeea2d30d9f5a53446ac79feb Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:48:19 +0100 Subject: [PATCH 23/43] add checkout repo --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 3650a82..1a91e31 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -5,4 +5,5 @@ jobs: Explore-GitHub-Actions: runs-on: ubuntu-latest steps: + - uses: actions/checkout@v4 - run: yarn test \ No newline at end of file From fb86ce6d48e65b6caa3c2ea0352bd0db6cd9852a Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:48:43 +0100 Subject: [PATCH 24/43] add setup node js --- .github/workflows/run-tests.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 1a91e31..fbce1b1 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -6,4 +6,8 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '20' - run: yarn test \ No newline at end of file From 5c20ad9a8cf1c351643fb14c51d9d42914391d16 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:49:50 +0100 Subject: [PATCH 25/43] add yarn install --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index fbce1b1..5d7f072 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -10,4 +10,5 @@ jobs: uses: actions/setup-node@v3 with: node-version: '20' + - run: yarn install - run: yarn test \ No newline at end of file From ab24e9ece7e2ac8fd1930809c979fb91489b675d Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 21 Feb 2024 17:50:17 +0100 Subject: [PATCH 26/43] rename test --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5d7f072..4d2c4f5 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -2,7 +2,7 @@ name: GitHub Actions Demo run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 on: [push] jobs: - Explore-GitHub-Actions: + run-tests: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From 4db296579304059f09e46f123b0de2d2246e92df Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 11:49:26 +0100 Subject: [PATCH 27/43] change test text to correct value --- packages/app/e2e-tests/app.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/e2e-tests/app.test.ts b/packages/app/e2e-tests/app.test.ts index d45bc0d..9807ea2 100644 --- a/packages/app/e2e-tests/app.test.ts +++ b/packages/app/e2e-tests/app.test.ts @@ -19,5 +19,5 @@ import { test, expect } from '@playwright/test'; test('App should render the welcome page', async ({ page }) => { await page.goto('/'); - await expect(page.getByText('My Company Catalog')).toBeVisible(); + await expect(page.getByText('Scaffolded Backstage App')).toBeVisible(); }); From 60709c5afa1181c47103d3365e6194153daca89d Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 11:49:43 +0100 Subject: [PATCH 28/43] add end to end tests --- .github/workflows/run-tests.yml | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 4d2c4f5..4c87327 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -11,4 +11,15 @@ jobs: with: node-version: '20' - run: yarn install - - run: yarn test \ No newline at end of file + - run: yarn test + + run-e2e-tests: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 + - name: Use Node.js + uses: actions/setup-node@v3 + with: + node-version: '20' + - run: yarn install + - run: yarn playwright test \ No newline at end of file From 85c594243a2f39693dbc913914e41a53905b4226 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 12:10:09 +0100 Subject: [PATCH 29/43] add playwright url for test env --- .github/workflows/run-tests.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 4c87327..2a6294a 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -14,6 +14,8 @@ jobs: - run: yarn test run-e2e-tests: + env: + PLAYWRIGHT_URL: http:/localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 From 59668f5795467b04d3df82a975fc5ced9b650378 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 12:18:37 +0100 Subject: [PATCH 30/43] add install playwright browser --- .github/workflows/run-tests.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 2a6294a..9693c20 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -23,5 +23,9 @@ jobs: uses: actions/setup-node@v3 with: node-version: '20' - - run: yarn install - - run: yarn playwright test \ No newline at end of file + - name: Install dependencies + run: yarn install + - name: Install Playwright Browsers + run: yarn playwright install --with-deps + - name: Run E2E tests + run: yarn playwright test From 32d3d09dad0ff6916860d4139996dcce67a003a7 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:14:33 +0100 Subject: [PATCH 31/43] fix: typo in localhost --- .github/workflows/run-tests.yml | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 9693c20..0fe9046 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,6 +1,7 @@ name: GitHub Actions Demo run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 on: [push] + jobs: run-tests: runs-on: ubuntu-latest @@ -15,7 +16,7 @@ jobs: run-e2e-tests: env: - PLAYWRIGHT_URL: http:/localhost:3000 + PLAYWRIGHT_URL: http://localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -25,7 +26,7 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - - name: Install Playwright Browsers - run: yarn playwright install --with-deps + # - name: Install Playwright Browsers + # run: yarn playwright install --with-deps - name: Run E2E tests - run: yarn playwright test + run: yarn test:e2e From fb495c76bbf5a407f2ca479ca57ba78ffa9b195b Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:21:08 +0100 Subject: [PATCH 32/43] test: add some logging --- .github/workflows/run-tests.yml | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 0fe9046..5435ef0 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -15,8 +15,6 @@ jobs: - run: yarn test run-e2e-tests: - env: - PLAYWRIGHT_URL: http://localhost:3000 runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 @@ -26,7 +24,14 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - # - name: Install Playwright Browsers - # run: yarn playwright install --with-deps + - name: Install Playwright Browsers + run: yarn playwright install --with-deps - name: Run E2E tests - run: yarn test:e2e + env: + PLAYWRIGHT_URL: http://localhost:3000 + run: | + echo $PLAYWRIGHT_URL + ls + pwd + ls packages + yarn test:e2e From 515093fd2b6d86e0731ac1b139ff02601b22c871 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:33:44 +0100 Subject: [PATCH 33/43] test: ci env variable --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 5435ef0..300516c 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -31,6 +31,7 @@ jobs: PLAYWRIGHT_URL: http://localhost:3000 run: | echo $PLAYWRIGHT_URL + echo $CI ls pwd ls packages From 158228dcd4f03cfe8cac55d4b79741af2fcbed6a Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:39:16 +0100 Subject: [PATCH 34/43] fix: make CI env variable empty --- .github/workflows/run-tests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 300516c..93d6e7d 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,6 +29,7 @@ jobs: - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 + CI: run: | echo $PLAYWRIGHT_URL echo $CI From 571414c6340f78d588d739609bf8860f501da570 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 13:54:14 +0100 Subject: [PATCH 35/43] fix: unset CI env var, set by default in GithHub Actions --- .github/workflows/run-tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 93d6e7d..7c51103 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -29,11 +29,6 @@ jobs: - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 - CI: + CI: # unset CI because it is set by default in Github actions run: | - echo $PLAYWRIGHT_URL - echo $CI - ls - pwd - ls packages yarn test:e2e From 0461793901e983c5d608619b76df5d6e155f4321 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Tue, 27 Feb 2024 16:05:52 +0100 Subject: [PATCH 36/43] try without playwright browser --- .github/workflows/run-tests.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 7c51103..237281f 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -24,11 +24,11 @@ jobs: node-version: '20' - name: Install dependencies run: yarn install - - name: Install Playwright Browsers - run: yarn playwright install --with-deps + #- name: Install Playwright Browsers + # run: yarn playwright install --with-deps - name: Run E2E tests env: - PLAYWRIGHT_URL: http://localhost:3000 + PLAYWRIGHT_URL: http://localhost:3000 # set the URL of the app to test with playwright CI: # unset CI because it is set by default in Github actions run: | yarn test:e2e From de3f34e2991989825d631461c46312d84949a3cb Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 28 Feb 2024 13:34:33 +0100 Subject: [PATCH 37/43] add pre commit tests --- package.json | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/package.json b/package.json index 09c3be2..690bf7d 100644 --- a/package.json +++ b/package.json @@ -31,6 +31,10 @@ "docker:remove-all": "docker compose down", "new": "backstage-cli new --scope internal" }, + "pre-commit": [ + "yarn test", + "yarn e2e-test" + ], "workspaces": { "packages": [ "packages/*", @@ -62,4 +66,5 @@ "prettier --write" ] } + } From 60371e7efe287e25f00db4a008f4f8ea0c5acf71 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Wed, 28 Feb 2024 13:37:30 +0100 Subject: [PATCH 38/43] this is a test commit --- .github/workflows/run-tests.yml | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 237281f..062d7e8 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,7 +1,8 @@ -name: GitHub Actions Demo -run-name: ${{ github.actor }} is testing out GitHub Actions 🚀 -on: [push] +name: Test and E2E tests +run-name: Run tests and E2E tests +on: [push] +test jobs: run-tests: runs-on: ubuntu-latest @@ -17,12 +18,12 @@ jobs: run-e2e-tests: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v4 #chekcout te repository - name: Use Node.js - uses: actions/setup-node@v3 + uses: actions/setup-node@v3 #setup node version 20 with: node-version: '20' - - name: Install dependencies + - name: Install dependencies #install dependencies run: yarn install #- name: Install Playwright Browsers # run: yarn playwright install --with-deps From 9cb53d606f98cc12edd2e453e55cc7ef9a0c1ea4 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 17:05:01 +0100 Subject: [PATCH 39/43] change test comand --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 690bf7d..2ec8570 100644 --- a/package.json +++ b/package.json @@ -16,7 +16,7 @@ "tsc": "tsc", "tsc:full": "tsc --skipLibCheck false --incremental false", "clean": "backstage-cli repo clean", - "test": "backstage-cli repo test", + "test": "backstage-cli repo test && playwright test", "test:all": "backstage-cli repo test --coverage", "test:e2e": "playwright test", "fix": "backstage-cli repo fix", From 94f399b00106bd8d5ded1f2ef4d5dad06cc8e816 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 17:05:13 +0100 Subject: [PATCH 40/43] change when test runs --- .github/workflows/run-tests.yml | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 062d7e8..8caea7f 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -1,8 +1,11 @@ name: Test and E2E tests run-name: Run tests and E2E tests -on: [push] -test +on: + push: + pull_request: + branches: + - main jobs: run-tests: runs-on: ubuntu-latest @@ -23,10 +26,10 @@ jobs: uses: actions/setup-node@v3 #setup node version 20 with: node-version: '20' + - name: Install dependencies #install dependencies run: yarn install - #- name: Install Playwright Browsers - # run: yarn playwright install --with-deps + - name: Run E2E tests env: PLAYWRIGHT_URL: http://localhost:3000 # set the URL of the app to test with playwright From 18ce80c333bee7fa4b4f585c706fde7cff34dbc2 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 18:47:02 +0100 Subject: [PATCH 41/43] change backstage url port in e2e test --- packages/app/src/App.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/app/src/App.test.tsx b/packages/app/src/App.test.tsx index ec8ba1d..824bc54 100644 --- a/packages/app/src/App.test.tsx +++ b/packages/app/src/App.test.tsx @@ -10,7 +10,7 @@ describe('App', () => { { data: { app: { title: 'Test' }, - backend: { baseUrl: 'http://localhost:7007' }, + backend: { baseUrl: 'http://localhost:3000' }, techdocs: { storageUrl: 'http://localhost:7007/api/techdocs/static/docs', }, From c21039a34b58e9fa3df7a53b111c14927ac55b32 Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 18:53:59 +0100 Subject: [PATCH 42/43] Update test command in run-tests.yml --- .github/workflows/run-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml index 8caea7f..2427e31 100644 --- a/.github/workflows/run-tests.yml +++ b/.github/workflows/run-tests.yml @@ -16,7 +16,7 @@ jobs: with: node-version: '20' - run: yarn install - - run: yarn test + - run: yarn backstage-cli repo test run-e2e-tests: runs-on: ubuntu-latest From 12635816415fd4a3e9f496090c39684c2eccc85f Mon Sep 17 00:00:00 2001 From: juliusdw Date: Thu, 7 Mar 2024 18:59:20 +0100 Subject: [PATCH 43/43] add testing section to readme --- README.md | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/README.md b/README.md index 6324793..e07510c 100644 --- a/README.md +++ b/README.md @@ -298,3 +298,17 @@ This file changes some base values that are necessary to build the correct image **`app-config.production.yaml`:**
This file adds one line to the kubernetes plugin setup, which is only needed if the app is hosted inside of a kubernetes cluster. + +# Testing + +Before committing your changes, run the tests pls. ✨ + +```sh +yarn test +``` + +to run tests without end to end testing run: + +```sh +yarn backstage-cli repo test +``` \ No newline at end of file