Skip to content

Fix session-start script shell compatibility #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix session-start script shell compatibility #7

merged 1 commit into from
Nov 29, 2024

Conversation

@codevalve
Copy link
Owner

@codevalve codevalve commented Nov 29, 2024

This PR fixes a shell compatibility issue in the session-start script by replacing process substitution with a more compatible for loop approach.

Changes:

  • Modified check_required_tools function to use a standard for loop
  • Improved shell compatibility across different environments
  • Removed syntax error when running with sh

Tested:

  • Verified script runs without errors using sh
  • Confirmed required tools checking still works as expected

@codevalve codevalve merged commit becf913 into main Nov 29, 2024
@codevalve codevalve deleted the fix/session-start-script-syntax branch November 29, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@codevalve