From 5c6df7d6dd8eab09dd536b6b16a21a6044dba0cf Mon Sep 17 00:00:00 2001 From: Tim Fischbach Date: Tue, 12 May 2015 18:32:14 +0200 Subject: [PATCH] Improve SubsetCollection * Remove models when they are removed from the parent * Correctly call add when models are added to the parent --- .../pageflow/editor/collections/subset_collection.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/pageflow/editor/collections/subset_collection.js b/app/assets/javascripts/pageflow/editor/collections/subset_collection.js index 5c33e74625..b85e2bc008 100644 --- a/app/assets/javascripts/pageflow/editor/collections/subset_collection.js +++ b/app/assets/javascripts/pageflow/editor/collections/subset_collection.js @@ -16,10 +16,14 @@ pageflow.SubsetCollection = Backbone.Collection.extend({ this.listenTo(this.parent, 'add', function(model, collection, options) { if (!adding && this.filter(model)) { - this.add(model, collection, options); + this.add(model, options); } }); + this.listenTo(this.parent, 'remove', function(model) { + this.remove(model); + }); + this.listenTo(this, 'add', function(model, collection, options) { adding = true; this.parent.add(model);