-
Notifications
You must be signed in to change notification settings - Fork 129
Implements skip link for navigation #1585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It adds a skip link for better navigation It adds an invisible link to the content and the same functionality can be extended for further components as well While navigation using keyboard a link appear which refers to the content. It increases usability for users who wants to skip navigation bar and go directly to content It renders a button which will only be visible on tab press and will disappear once clicked or skipped Works with both mouse click and enter
The approach to use JS was complicated and using just :focus selector fixed the issue and made it more robust and easy It also removes the dynamic anchor element and adds an id to the entry element
| position: absolute; | ||
| left: 23%; | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chapter list covers the whole navigation bar. So, if a user skips links one time then he has to use keyboard to use the skip link again.
So if a user clicks on navigation bar and hit tab then without this the first chapter list item is focused.
This also doesn't provide a considerable solution as it only makes the chapter list smaller so the user has some space between the chapter list and the logo to click and use the skip link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed this for now. Let me know if this makes sense and I will add it again or any other idea you have for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think that's fine. The user can always return to the top of the tab order by focusing the location bar (Crtl+L etc.)
878afe0 to
f6a55c2
Compare
It scrolls down and skip navigation on clicking the skip link to give the user a feel that the navigation links are skipped It also fix the alignment of the button
3cab299 to
33ea1b0
Compare
REDMINE-17403
It adds a skip link for better navigation
It adds an invisible link to the content and
the same functionality can be extended for further
components as well
While navigation using keyboard a link appear which refers
to the content. It increases usability for users who wants
to skip navigation bar and go directly to content
It renders a button which will only be visible on tab press
and will disappear once clicked or skipped
Works with both mouse click and enter