Player controls changes #1586
Merged
Player controls changes #1586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tf
force-pushed
the
player-controls-changes
branch
2 times, most recently
from
562111f to
69e5bb3
Compare
Fix text tracks position accordingly. REDMINE-17746
* Display big play button on poster when the element has not yet played. Return to unplayed state on end. * Allow passing `via` option to player actions to store whether the player was played or paused via the play/pause button. That way we can display the animated play and pause icons on the video/poster when the element autoplays/autopauses or the poster is clicked. When clicking play/pause button, displaying the icons seems redundant. REDMINE-17746
* Display time and text tracks menu on poster and aligned to the right to match inset position of classic controls. * Keep big play/pause button which now resembled big button on classic poster. * Display bar background only in stand alone mode. REDMINE-17746, REDMINE-17677
REDMINE-17677
Pulling file lookup up into the content element lets us use the poster file instead of the id to determine whether audio controls are in stand alone mode. This ensures the mode is set correctly, when an image file is deleted from the entry: The id might still be present in the configuration, but the file itself can no longer be looked up. Already before, we started moving towards passing file objects instead of ids for the actual audio and video files. So this change makes things more consistent. REDMINE-17746
So far `playBlessed` action only unmuted the first time it is dispatched. This made it impossible to pause players by clicking the poster since clicking the poster always tried to unmute by dispatching `playBlessed`. Before the introduction of the mute/unmute button, this could not happen since there was no way to mute the entry again. REDMINE-17746
tf
force-pushed
the
player-controls-changes
branch
from
b3a3391 to
7568fcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REDMINE-17746, REDMINE-17677