Skip to content

Loading spinner preview fix #1595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
awaismbajwa wants to merge 1 commit into from
Closed

Loading spinner preview fix #1595

awaismbajwa wants to merge 1 commit into from

Conversation

@awaismbajwa
Copy link
Contributor

@awaismbajwa awaismbajwa commented Oct 27, 2020

REDMINE-17738

@coveralls
Copy link

coveralls commented Oct 27, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 99.193% when pulling c708a03 on awaismbajwa:loading-spinner-preview-fix into 78be38e on codevise:master.

@awaismbajwa awaismbajwa force-pushed the loading-spinner-preview-fix branch from ba5cf2e to 6b29128 Compare October 28, 2020 08:59
@awaismbajwa
Changes:
c708a03 
* do not set loading_spinner initial display property to none.
* include fadeout animation in fade class.
* changes in ClassicLoadingSpinner.jsx to loop spinner fading in preview mode.
@awaismbajwa awaismbajwa force-pushed the loading-spinner-preview-fix branch from 6b29128 to c708a03 Compare October 28, 2020 09:18
@awaismbajwa awaismbajwa requested a review from tf October 28, 2020 09:19
@tf
Copy link
Member

tf commented Jan 8, 2021

see #1649

@tf tf closed this Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tf tf Awaiting requested review from tf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awaismbajwa @coveralls @tf