Pictogram visiblity #584
Closed
Pictogram visiblity #584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lambda now takes the filename as a second parameter.
Image assets no long seem to be picked up automatically.
application.js requires turbolinks gem which is not present.
* Add variant displaying logo on all pages * Add variables for logo dimensions
* Timestamp positions * Font size * Borders
Ensure boundary events trigger when the position is reset. This ensures that header logos can be faded out correctly when scrolling back to a page with position bottom.
When scrolling back to a page the class may not be set since we are at the bottom of the page. Rely completely on the scroller events of the current page. Detect current page via comparison with `slides.currentPage`, since the `active` class on page is set with a delay.
Allow to fade in watermark logo on all pages.
Allow specifying color. Default to main color.
Instead of borderless box with triangle arrow.
Info box had been repositioned in codevise#576 to allow transparent control bars. On mobile the position has to stay the same though.
We need to take border width into account when positioning the info box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.