Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase the test coverage #603

Merged
merged 1 commit into from
Aug 22, 2016
Merged

increase the test coverage #603

merged 1 commit into from
Aug 22, 2016

Conversation

tilsammans
Copy link
Contributor

  • removed unused tests
  • introduced test file for files_helper
  • added tests for video_files_helper

houndci-bot
houndci-bot reviewed Aug 20, 2016
View reviewed changes
spec/helpers/pageflow/video_files_helper_spec.rb
html = helper.mobile_poster_image_div(
"video_file_id" => 96,
"video_file_x" => 20,
"video_file_y" => 20
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer single-quoted strings when you don't need string interpolation or special symbols.

@tilsammans
increase the test coverage
75a9849 
* removed unused tests
* introduced test file for files_helper
* added tests for video_files_helper
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 99.024% when pulling 75a9849 on scrollytelling:increase-coverage into e1c8be2 on codevise:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 99.024% when pulling 75a9849 on scrollytelling:increase-coverage into e1c8be2 on codevise:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 99.044% when pulling 75a9849 on scrollytelling:increase-coverage into e1c8be2 on codevise:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 98.973% when pulling 75a9849 on scrollytelling:increase-coverage into e1c8be2 on codevise:master.

@tf tf added this to the v0.11 milestone Aug 22, 2016
@tf tf merged commit b3c0f5a into codevise:master Aug 22, 2016
@tilsammans tilsammans deleted the increase-coverage branch August 22, 2016 08:36
@tilsammans
Copy link
Contributor Author

👍

This was the low-hanging fruit. Eventually I will try to address all the missing coverage, but due to time constraints that won't be soon.

@tf
Copy link
Member

tf commented Aug 22, 2016

Thanks. While I don't think coverage should be a goal in itself as a quality measure, having 100% coverage is a great tool for dead code detection. Especially in spec/support/dominos there is some unused stuff for example. Just FYI, some of the front end related helpers might not be worth tackling since they will probably go away soon, when the built in page types will be ported to use pageflow-react.

@tilsammans
Copy link
Contributor Author

The work on pageflow-react is partly why I didn't want to go too far with this. It should be a nice and performant update, looking forward to what will happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.11
Development

Successfully merging this pull request may close these issues.
4 participants
@tilsammans @coveralls @tf @houndci-bot