Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to programatically re-enable atmo on mobile devices #670

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Allow to programatically re-enable atmo on mobile devices #670

merged 1 commit into from
Nov 11, 2016

Conversation

tilsammans
Copy link
Contributor

This way, sites have the option to force this value after the Pageflow
javascript-code is done initialising.

See #554 for previous discussion.

This way, sites have the option to force this value after the Pageflow
javascript-code is done initialising.
@tilsammans
Copy link
Contributor Author

@tf what do you think of this change?

It would allow us to enable the value in the application.js, thereby ignoring the default.

@coveralls
Copy link

coveralls commented Nov 7, 2016

Coverage Status

Coverage remained the same at 99.053% when pulling e2f36f4 on scrollytelling:atmo-disabled-config into bfe5e70 on codevise:master.

@tf
Copy link
Member

tf commented Nov 11, 2016

I guess that's fine. It should then be safe to call pageflow.atmo.enable() when the pageflow.ready promise resolves.

@tf
Copy link
Member

tf commented Nov 11, 2016

The help texts will still claim that atmo is disabled on mobile, though. But the medium term goal has to be making atmo work on mobile anyway since technically it should be possible by reusing audio elements.

@tf tf merged commit 306a53f into codevise:master Nov 11, 2016
@tf tf changed the title move disabled into the initializer Allow to programatically re-enable atmo on mobile devices Nov 11, 2016
@tf tf added this to the v0.12 milestone Nov 11, 2016
@tilsammans tilsammans deleted the atmo-disabled-config branch November 11, 2016 12:00
@tilsammans
Copy link
Contributor Author

Just to be sure, that would be this code, right?

pageflow.ready.then(function(result) {
  pageflow.atmo.enable();
});

@tf
Copy link
Member

tf commented Nov 11, 2016

I think so, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants