Skip to content

Fix ParameterizedTests suppressing PreconditionViolationException #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kazk merged 5 commits into from
Feb 2, 2023
Merged

Fix ParameterizedTests suppressing PreconditionViolationException #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c3257d
JUnit5 ParameterizedTests suppress PreconditionViolationException and…
hobovsky Feb 1, 2023
5f4f728
Restore original indentation (hopefully)
hobovsky Feb 1, 2023
470e207
Apply remarks from review
hobovsky Feb 1, 2023
61f6249
Remove unnecessary empty line
hobovsky Feb 1, 2023
460cf4c
Improve formatting of crash message
hobovsky Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion src/main/java/com/codewars/junit5/CodewarsListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,14 @@ public void executionFinished(TestIdentifier testIdentifier, TestExecutionResult
} else {
System.out.println("\n<FAILED::>Failed for unknown cause");
}
} else {
++failures;
Optional<Throwable> th = testExecutionResult.getThrowable();
if (th.isPresent()) {
outputError("Crashed", th.get());
} else {
System.out.println("\n<ERROR::>Unexpected error occurred");
}
}
System.out.printf("\n<COMPLETEDIN::>%d\n", getDuration(testIdentifier));
break;
Expand Down Expand Up @@ -161,6 +169,17 @@ private static void outputFailure(String kind, Throwable throwable) {
System.out.printf("\n<LOG:ESC:-Stack Trace>%s\n", formatMessage(readStackTrace(throwable)));
}

private static void outputError(String kind, Throwable throwable) {
String msg = throwable.getMessage();
String formattedStackTrace = formatMessage(readStackTrace(throwable));
if (msg == null) {
System.out.printf("\n<ERROR::>Test %s<:LF:><:LF:>%s\n", kind, formattedStackTrace);
} else {
String formattedMessage = formatMessage(msg);
System.out.printf("\n<ERROR::>%s<:LF:><:LF:>%s\n", formattedMessage, formattedStackTrace);
}
}

// Read the stacktrace of the supplied {@link Throwable} into a String.
// https://github.com/junit-team/junit5/blob/946c5980074f466de0688297a6d661d32679599a/junit-platform-commons/src/main/java/org/junit/platform/commons/util/ExceptionUtils.java#L76
private static String readStackTrace(Throwable throwable) {
Expand All @@ -186,7 +205,7 @@ private long getDuration(TestIdentifier testIdentifier) {
}

private static String formatMessage(final String s) {
return (s == null) ? "" : s.replaceAll("\n", "<:LF:>");
return (s == null) ? "" : s.replaceAll(System.lineSeparator(), "<:LF:>");
}

private NavigableSet<String> reportEntries(TestIdentifier testIdentifier) {
Expand Down