Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upFix commands execution #4
Conversation
khaydarov
added some commits
Apr 1, 2019
DorofeevMark
reviewed
Apr 1, 2019
| for (let key = 0; key < shortcut.length; key++) { | ||
| shortcut[key] = shortcut[key].toUpperCase(); | ||
|
|
||
| let isCommand = false; |
This comment has been minimized.
This comment has been minimized.
DorofeevMark
Apr 1, 2019
Может проще так?
if (Object.keys(keyCodes).indexOf(shortcut[key]) === -1) {
neSpecc
approved these changes
Apr 1, 2019
DorofeevMark
approved these changes
Apr 4, 2019
khaydarov
merged commit 40e4a91
into
master
Apr 5, 2019
khaydarov
deleted the
fix-commands-execution
branch
Apr 5, 2019
This was referenced Apr 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
khaydarov commentedApr 1, 2019
No description provided.