Skip to content

/editor.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core API]: Provide methods that opens/closes inline toolbar #665

Closed
khaydarov opened this issue Apr 2, 2019 · 2 comments

Comments

Assignees
No one assigned
Labels
good first task
Projects
  
Done in Roadmap Q2 2019
Milestone
No milestone
2 participants
@khaydarov @neSpecc
@khaydarov
Copy link
Member

commented Apr 2, 2019

No description provided.

@neSpecc neSpecc added the good first task label Apr 9, 2019

@neSpecc neSpecc added this to Sheduled in Roadmap Q2 2019 Apr 9, 2019

@neSpecc neSpecc changed the title [API]: Provide methods that opens/closes inline toolbar [Core API]: Provide methods that opens/closes inline toolbar Apr 9, 2019

@neSpecc neSpecc referenced this issue Apr 9, 2019

Open

Close Toolbar after Link insertion #600

@neSpecc

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 9, 2019

I thought, it should be done same way as Toolbar API module with open and close methods.

https://github.com/codex-team/editor.js/blob/master/src/components/modules/api/toolbar.ts

@tanmayv tanmayv referenced this issue Apr 9, 2019

Merged

#665 API to open and close inline-toolbar #711

@neSpecc neSpecc moved this from Sheduled to On review in Roadmap Q2 2019 Apr 9, 2019

neSpecc added a commit that referenced this issue Apr 11, 2019

@tanmayv @neSpecc
#665 API to open and close inline-toolbar (#711) 
* API to open and close inline-toolbar

* Fixed documentation

* renamed inline -> inline-toolbar

* removed dist

* reset editor.js

* added editor.js bundle

* Fixed build error

* Null checks on toolbar/inline@open

* updated bundle

* Improve some comments

* Updatd api.md CHANGELOG.md

* Change feature to new instead of improvement
f554945

@neSpecc neSpecc moved this from On review to Done in Roadmap Q2 2019 Apr 11, 2019

@neSpecc

This comment has been minimized.

Sign in to view
Copy link
Member

commented Apr 11, 2019

Resolved by #665, thanks @tanmayv

@neSpecc neSpecc closed this Apr 11, 2019

neSpecc added a commit that referenced this issue Apr 29, 2019

@gohabereg @neSpecc
Version 2.13 (#719) 
* Do not start multi-block selection on UI elements (#662)

* Do not start multi-block selection on UI elements

* Do not prevent mousedown event on inline toolbar actions

* Remove log

* Add comment

* Add link to issue

closes #646

* Fix loss of pointer (#666)

* Fix loss of pointer when click is outside of the editor but selection is inside

* Remove log

* Update shortcuts module (#685)

* Fixed possible grammatical typo (#681)

Thanks

* Update shortcuts module

* update changelog

* update

* Remove margin top for inline-link icon (#690)

* Remove margin top for inline-link icon

resolves #674

* Update CHANGELOG.md

* Remove unused style

* Pull fresh tools

* Remove changelog contents from readme (#700)

* #665 API to open and close inline-toolbar (#711)

* API to open and close inline-toolbar

* Fixed documentation

* renamed inline -> inline-toolbar

* removed dist

* reset editor.js

* added editor.js bundle

* Fixed build error

* Null checks on toolbar/inline@open

* updated bundle

* Improve some comments

* Updatd api.md CHANGELOG.md

* Change feature to new instead of improvement

* Allow holderId work with ref on dom element (#710)

* done

* update types

* attempt to simplify code

* remove useless helper

* revert holderId logic and add holder property

* Apply suggestions from code review

Co-Authored-By: dimensi <eddimensi@gmail.com>

* update holder type on string | HTMLElement

* fix typo

* add deprecated notice and fix typos

* fix wrong compare

* fix comments

* swap console.log on _.log

* update types for editor config

* update examples

* update docs

* update build

* Activating Open Collective (#736)

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/editorjs❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info](https://github.com/opencollective/opencollective/wiki/Github-banner). See how it looks on this [repo](https://github.com/apex/apex#backers).

You can also add a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info](https://github.com/OpenCollective/opencollective-cli)
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

* Do not install editor.js as dev-dependency (#731)

Resolves #730

* Move codex-notifier to dependencies for typescript declarations (#728)

* Close inline toolbar after creating new link by pressing ENTER (#722)

* Method to clear current selection and close inline toolbar

* clearSelection with optional collapsed range

* refactored selection.ts

* removed experimental function

* Update src/components/selection.ts

Co-Authored-By: tanmayv <12tanmayvijay@gmail.com>

* update version, add changelog

* Link Logo Image to homepage (#738)

* Update README.md (#744)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Co-Authored-By: neSpecc <specc.dev@gmail.com>

* Config minHeight option that allows to customize bottom zone (#745)

* issue-739: allow Block's editable element selection (#747)

* issue-739: allow Block's input selection

* little improvements

* update Changelog and cache inputs

* small fix

* delete map file

* fix inputs.count condition

* Fix typo in example paragraph (#749)

* Fix typo

* Update example-dev.html

* minor release
Loading status checks…
79f8660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.