Skip to content

/editor.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not start multi-block selection on UI elements #662

Merged
merged 4 commits into from Apr 4, 2019
+41 −20

Conversation

Reviewers

@neSpecc neSpecc

@khaydarov khaydarov

@talyguryn talyguryn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@gohabereg @neSpecc @khaydarov @talyguryn
@gohabereg
Copy link
Member

commented Apr 1, 2019

close #646

@gohabereg gohabereg requested review from khaydarov, neSpecc and talyguryn as code owners Apr 1, 2019

@neSpecc

neSpecc requested changes Apr 2, 2019
View changes

Copy link
Member

left a comment

— still can not select and edit link
@khaydarov

khaydarov reviewed Apr 2, 2019
View changes

src/components/modules/toolbar/inline.ts Outdated
@@ -83,7 +83,10 @@ export default class InlineToolbar extends Module {

// To prevent reset of a selection when click on the wrapper
this.Editor.Listeners.on(this.nodes.wrapper, 'mousedown', (event) => {
event.preventDefault();
if (!(event.target as Element).closest(`.${this.CSS.actionsWrapper}`)) {
console.log('prevented');

This comment has been minimized.

Sign in to view
Copy link
@khaydarov

khaydarov Apr 2, 2019

Member

лог забыл
@neSpecc

neSpecc requested changes Apr 2, 2019
View changes

src/components/modules/toolbar/inline.ts Outdated
@@ -83,7 +83,9 @@ export default class InlineToolbar extends Module {

// To prevent reset of a selection when click on the wrapper
this.Editor.Listeners.on(this.nodes.wrapper, 'mousedown', (event) => {
event.preventDefault();
if (!(event.target as Element).closest(`.${this.CSS.actionsWrapper}`)) {

This comment has been minimized.

Sign in to view
Copy link
@neSpecc

neSpecc Apr 2, 2019

Member

вынеси в переменную

This comment has been minimized.

Sign in to view
Copy link
@neSpecc

neSpecc Apr 2, 2019

Member

и напиши коммент
@neSpecc

neSpecc approved these changes Apr 4, 2019
View changes

@khaydarov

khaydarov approved these changes Apr 4, 2019
View changes

@talyguryn

talyguryn approved these changes Apr 4, 2019
View changes

Copy link
Member

left a comment

вроде работает

@gohabereg gohabereg changed the base branch from master to release/2.12.4 Apr 4, 2019

@gohabereg gohabereg changed the base branch from release/2.12.4 to release/2.12 Apr 4, 2019

@gohabereg gohabereg merged commit 84689b5 into release/2.12 Apr 4, 2019

@gohabereg gohabereg deleted the fix/issue-646 branch Apr 4, 2019

gohabereg added a commit that referenced this pull request Apr 6, 2019

@gohabereg
Version 2.12.4 (#680) 
* Do not start multi-block selection on UI elements (#662)

* Do not start multi-block selection on UI elements

* Do not prevent mousedown event on inline toolbar actions

* Remove log

* Add comment

* Add link to issue

closes #646

* Fix loss of pointer (#666)

* Fix loss of pointer when click is outside of the editor but selection is inside

* Remove log

* Update shortcuts module (#685)

* Fixed possible grammatical typo (#681)

Thanks

* Update shortcuts module

* update changelog

* update

* Remove margin top for inline-link icon (#690)

* Remove margin top for inline-link icon

resolves #674

* Update CHANGELOG.md

* Remove unused style

* Pull fresh tools
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
ce69182

neSpecc added a commit that referenced this pull request Apr 29, 2019

@gohabereg @neSpecc
Version 2.13 (#719) 
* Do not start multi-block selection on UI elements (#662)

* Do not start multi-block selection on UI elements

* Do not prevent mousedown event on inline toolbar actions

* Remove log

* Add comment

* Add link to issue

closes #646

* Fix loss of pointer (#666)

* Fix loss of pointer when click is outside of the editor but selection is inside

* Remove log

* Update shortcuts module (#685)

* Fixed possible grammatical typo (#681)

Thanks

* Update shortcuts module

* update changelog

* update

* Remove margin top for inline-link icon (#690)

* Remove margin top for inline-link icon

resolves #674

* Update CHANGELOG.md

* Remove unused style

* Pull fresh tools

* Remove changelog contents from readme (#700)

* #665 API to open and close inline-toolbar (#711)

* API to open and close inline-toolbar

* Fixed documentation

* renamed inline -> inline-toolbar

* removed dist

* reset editor.js

* added editor.js bundle

* Fixed build error

* Null checks on toolbar/inline@open

* updated bundle

* Improve some comments

* Updatd api.md CHANGELOG.md

* Change feature to new instead of improvement

* Allow holderId work with ref on dom element (#710)

* done

* update types

* attempt to simplify code

* remove useless helper

* revert holderId logic and add holder property

* Apply suggestions from code review

Co-Authored-By: dimensi <eddimensi@gmail.com>

* update holder type on string | HTMLElement

* fix typo

* add deprecated notice and fix typos

* fix wrong compare

* fix comments

* swap console.log on _.log

* update types for editor config

* update examples

* update docs

* update build

* Activating Open Collective (#736)

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/editorjs❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info](https://github.com/opencollective/opencollective/wiki/Github-banner). See how it looks on this [repo](https://github.com/apex/apex#backers).

You can also add a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info](https://github.com/OpenCollective/opencollective-cli)
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

* Do not install editor.js as dev-dependency (#731)

Resolves #730

* Move codex-notifier to dependencies for typescript declarations (#728)

* Close inline toolbar after creating new link by pressing ENTER (#722)

* Method to clear current selection and close inline toolbar

* clearSelection with optional collapsed range

* refactored selection.ts

* removed experimental function

* Update src/components/selection.ts

Co-Authored-By: tanmayv <12tanmayvijay@gmail.com>

* update version, add changelog

* Link Logo Image to homepage (#738)

* Update README.md (#744)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Co-Authored-By: neSpecc <specc.dev@gmail.com>

* Config minHeight option that allows to customize bottom zone (#745)

* issue-739: allow Block's editable element selection (#747)

* issue-739: allow Block's input selection

* little improvements

* update Changelog and cache inputs

* small fix

* delete map file

* fix inputs.count condition

* Fix typo in example paragraph (#749)

* Fix typo

* Update example-dev.html

* minor release
Loading status checks…
79f8660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.