Skip to content

/editor.js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close inline toolbar after creating new link by pressing ENTER #722

Merged
merged 8 commits into from Apr 27, 2019
+35 −17

Conversation

Reviewers

@khaydarov khaydarov

@gohabereg gohabereg

@neSpecc neSpecc

@talyguryn talyguryn

Assignees

@tanmayv tanmayv

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@tanmayv @neSpecc @khaydarov @gohabereg
@tanmayv
Copy link

commented Apr 11, 2019

I have kept old toolbar as well. But I think have to remove that. And use the inlineToolbar open/close method. Give me a confirmation and I'll make the change.

Reason for adding clear selection method. If selection was present, inline toolbar will reopen again after closing for that selection.
resolved #600

@tanmayv tanmayv requested review from gohabereg, khaydarov, neSpecc and talyguryn as code owners Apr 11, 2019

@khaydarov khaydarov assigned tanmayv Apr 11, 2019

@khaydarov

khaydarov reviewed Apr 11, 2019
View changes

Show resolved Hide resolved src/components/selection.ts
@gohabereg

gohabereg reviewed Apr 15, 2019
View changes

Show resolved Hide resolved src/components/selection.ts

gohabereg and others added some commits Apr 15, 2019

@gohabereg @tanmayv
Update src/components/selection.ts 
Co-Authored-By: tanmayv <12tanmayvijay@gmail.com>
8be224b
@tanmayv
merge with release/2.13
9569bd8
@neSpecc
Merge remote-tracking branch 'origin/release/2.13' into pr/722
Verified
This commit was signed with a verified signature.
@neSpecc neSpecc Peter Savchenko
GPG key ID: 63E739583C761566 Learn about signing commits
5707944
@neSpecc
update version, add changelog
Verified
This commit was signed with a verified signature.
@neSpecc neSpecc Peter Savchenko
GPG key ID: 63E739583C761566 Learn about signing commits
e41a1be
@neSpecc

neSpecc approved these changes Apr 27, 2019
View changes

@neSpecc neSpecc merged commit 27cbaa5 into codex-team:release/2.13 Apr 27, 2019

neSpecc added a commit that referenced this pull request Apr 29, 2019

@gohabereg @neSpecc
Version 2.13 (#719) 
* Do not start multi-block selection on UI elements (#662)

* Do not start multi-block selection on UI elements

* Do not prevent mousedown event on inline toolbar actions

* Remove log

* Add comment

* Add link to issue

closes #646

* Fix loss of pointer (#666)

* Fix loss of pointer when click is outside of the editor but selection is inside

* Remove log

* Update shortcuts module (#685)

* Fixed possible grammatical typo (#681)

Thanks

* Update shortcuts module

* update changelog

* update

* Remove margin top for inline-link icon (#690)

* Remove margin top for inline-link icon

resolves #674

* Update CHANGELOG.md

* Remove unused style

* Pull fresh tools

* Remove changelog contents from readme (#700)

* #665 API to open and close inline-toolbar (#711)

* API to open and close inline-toolbar

* Fixed documentation

* renamed inline -> inline-toolbar

* removed dist

* reset editor.js

* added editor.js bundle

* Fixed build error

* Null checks on toolbar/inline@open

* updated bundle

* Improve some comments

* Updatd api.md CHANGELOG.md

* Change feature to new instead of improvement

* Allow holderId work with ref on dom element (#710)

* done

* update types

* attempt to simplify code

* remove useless helper

* revert holderId logic and add holder property

* Apply suggestions from code review

Co-Authored-By: dimensi <eddimensi@gmail.com>

* update holder type on string | HTMLElement

* fix typo

* add deprecated notice and fix typos

* fix wrong compare

* fix comments

* swap console.log on _.log

* update types for editor config

* update examples

* update docs

* update build

* Activating Open Collective (#736)

Hi, I'm making updates for Open Collective. Either you or a supporter signed this repo up for Open Collective. This pull request adds backers and sponsors from your Open Collective https://opencollective.com/editorjs❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info](https://github.com/opencollective/opencollective/wiki/Github-banner). See how it looks on this [repo](https://github.com/apex/apex#backers).

You can also add a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info](https://github.com/OpenCollective/opencollective-cli)
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

* Do not install editor.js as dev-dependency (#731)

Resolves #730

* Move codex-notifier to dependencies for typescript declarations (#728)

* Close inline toolbar after creating new link by pressing ENTER (#722)

* Method to clear current selection and close inline toolbar

* clearSelection with optional collapsed range

* refactored selection.ts

* removed experimental function

* Update src/components/selection.ts

Co-Authored-By: tanmayv <12tanmayvijay@gmail.com>

* update version, add changelog

* Link Logo Image to homepage (#738)

* Update README.md (#744)

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

Co-Authored-By: neSpecc <specc.dev@gmail.com>

* Config minHeight option that allows to customize bottom zone (#745)

* issue-739: allow Block's editable element selection (#747)

* issue-739: allow Block's input selection

* little improvements

* update Changelog and cache inputs

* small fix

* delete map file

* fix inputs.count condition

* Fix typo in example paragraph (#749)

* Fix typo

* Update example-dev.html

* minor release
Loading status checks…
79f8660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.