Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upissue-705: Leaf BlockSettings and InlineTools via keyboard #723
+24,731
−84
Conversation
khaydarov
added some commits
Apr 12, 2019
khaydarov
changed the base branch from
master
to
release/2.13
Apr 12, 2019
gohabereg
reviewed
Apr 22, 2019
|
При нажатии на Enter на кнопке, повторное нажатие не работает (актуально например для перемещения блоков) |
khaydarov
added some commits
Apr 26, 2019
neSpecc
reviewed
Apr 27, 2019
| * @param {string} direction - leaf direction. Can be 'left' or 'right' | ||
| * @param {string} activeCSSClass - css class that will be added | ||
| */ | ||
| public static leafNodes(nodeList, activeIndex, direction, activeCSSClass = 'cdx-settings-button--active') { |
This comment has been minimized.
This comment has been minimized.
neSpecc
Apr 27, 2019
Member
- из названия и описания не понятно, что этот метод возвращает индекс.
- В доке не описан
@return activeCSSClassзахардкожен. Его можно сделать опциональным- где еще может применяться такой метод? ему точно надо быть в lib.dom?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
khaydarov commentedApr 12, 2019
No description provided.