Fixed few bugs #31
Merged
Fixed few bugs #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
inderpreetsingh01
commented
Jan 8, 2022
inderpreetsingh01
commented
- Updated GIT_TAG to main as per googletest
- pushed TensorCPU object created in the constructor to BNNMemory
- size was getting computed twice in reshape
czgdp1807
reviewed
Jan 9, 2022
| GIT_TAG main | ||
| SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/googletest-src" | ||
| BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/googletest-build" | ||
| TEST_COMMAND "") |
Member
There was a problem hiding this comment.
We should remove this option to install Google test in future via CMakeLists.txt. The reason is developers have their own environments (and hence own way of installing dependencies into it). Installing via CMake can make mess up that setting. For now this is fine but in future I think we should remove it.
Member
|
Thanks. Merged. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.