Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migration should return promise #141

Merged

Conversation

@alangecker
Copy link
Contributor

commented Aug 12, 2019

fixes #126 and hackmdio/codimd#1197

ERROR: Migration 20171009121200-longtext-for-mysql.js (or wrapper) didn't return a promise
ERROR: Migration 20180209120907-longtext-of-authorship.js (or wrapper) didn't return a promise
ERROR: Migration 20180306150303-fix-enum.js (or wrapper) didn't return a promise

same like hackmdio/codimd#1199

fix: migration should return promise
Signed-off-by: chandi <git@chandi.it>

@alangecker alangecker force-pushed the alangecker:fix/migration-should-return-promise branch from f4f65a9 to 6280e92 Aug 12, 2019

@SISheogorath SISheogorath added the bug label Aug 12, 2019

@SISheogorath SISheogorath merged commit ec83605 into codimd:master Aug 12, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected

@alangecker alangecker deleted the alangecker:fix/migration-should-return-promise branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.