Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Return String Instead Of Buffer For Docker Secrets #168

Merged
merged 2 commits into from Sep 3, 2019

Conversation

@dargmuesli
Copy link
Contributor

commented Sep 2, 2019

Prevents "TypeError: Cannot freeze array buffer views with elements".

Config: Return String Instead Of Buffer For Docker Secrets
Prevents "TypeError: Cannot freeze array buffer views with elements".

Signed-off-by: Jonas Thelemann <e-mail@jonas-thelemann.de>
@SISheogorath

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

We might need another function call here: https://nodejs.org/api/all.html#fs_fs_readfilesync_path_options

Docker Secrets: Use Encoding Parameter Directly
Signed-off-by: Jonas Thelemann <e-mail@jonas-thelemann.de>

@dargmuesli dargmuesli force-pushed the dargmuesli:fix/docker-secret-buffer branch from 01215b9 to 0be7843 Sep 3, 2019

@dargmuesli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 3, 2019

Ah yes, sure. I never really worked with node before, just for fixes like this :)

@SISheogorath SISheogorath merged commit 529075f into codimd:master Sep 3, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected
@SISheogorath

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

For that you do a great job 👍🏼

@dargmuesli

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

You do a great job too with giving a direction to work to with links to the documentation and not just giving the solution! That's how one learns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.