Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in lutim integration #217

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@gramakri
Copy link
Contributor

gramakri commented Oct 29, 2019

@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Oct 29, 2019

Good catch! could you please sign-off your commit?

https://github.com/codimd/server/blob/master/CONTRIBUTING.md#sign-your-work

@gramakri

This comment has been minimized.

Copy link
Contributor Author

gramakri commented Oct 29, 2019

@SISheogorath Will do, later today! Despite the fix, I haven't gotten lutim to work. still debugging that

@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Oct 29, 2019

If you feel like you need more help or at least look for more interactive support, don't forget to join our community channel: https://riot.im/app/#/room/#codimd:matrix.org

Signed-off-by: Girish Ramakrishnan <girish@cloudron.io>
@gramakri gramakri force-pushed the cloudron-io:lutim_crash branch from 6a41c28 to c034ee5 Oct 30, 2019
@gramakri

This comment has been minimized.

Copy link
Contributor Author

gramakri commented Oct 30, 2019

I have added the DCO

@SISheogorath SISheogorath merged commit 95aa0ee into codimd:master Oct 30, 2019
4 checks passed
4 checks passed
DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.