Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linkify header style #218

Merged
merged 7 commits into from Dec 3, 2019

Conversation

@hoijui
Copy link
Contributor

hoijui commented Oct 30, 2019

more changes (fixes) for the previous merge with the same goal.

In short: The GitHub conform naming did not work right, because of the deduplicateHeaderId() method.

These changes and fixes were developed over at:
hackmdio/codimd#1310

hoijui and others added 7 commits Oct 22, 2019
Co-Authored-By: Yukai Huang <yukaihuangtw@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
Signed-off-by: hoijui <hoijui.quaero@gmail.com>
@SISheogorath SISheogorath merged commit 33150b7 into codimd:master Dec 3, 2019
4 checks passed
4 checks passed
DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected
@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Dec 3, 2019

Thanks a lot!

@hoijui

This comment has been minimized.

Copy link
Contributor Author

hoijui commented Dec 3, 2019

:-) thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.