Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example config for gitlab authorization #248

Merged
merged 1 commit into from Jan 13, 2020

Conversation

@b10102016
Copy link
Contributor

b10102016 commented Jan 8, 2020

Update example config for gitlab authorization

@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Jan 11, 2020

Thanks for this PR! It's a nice first time contribution. To get this into our sources all you need to add is the sign-off to your commit.
https://github.com/codimd/server/blob/master/CONTRIBUTING.md#sign-your-work

In order to fix this, you should use your local got repository and rewrite this commit. How to do so? Well, there is some little CLI magic that helps:

#clone the right branch 
git clone -b patch-1 ssh://git@github.com:b10102016/server.git
cd server
#change the commit message and review your changes
git commit --amend --sign-off -v
# push the changes to your changed branch
git push -f

Hope that helps and I hope to see you around on the community forum or the community chat.

Update example config for gitlab authorization

Signed-off-by: Ian Tsai <b10102016@gmail.com>
@b10102016 b10102016 force-pushed the b10102016:patch-1 branch from 08455d6 to deb3b94 Jan 13, 2020
@b10102016

This comment has been minimized.

Copy link
Contributor Author

b10102016 commented Jan 13, 2020

Hi @SISheogorath ,

Thank for your reply. I have added the sign-off to my commit.
Please have a check.

Thanks~

@SISheogorath SISheogorath merged commit e222e44 into codimd:master Jan 13, 2020
4 checks passed
4 checks passed
DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected
@SISheogorath

This comment has been minimized.

Copy link
Member

SISheogorath commented Jan 13, 2020

Thanks a lot! Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.