Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix revision redirect to index page #267

Merged
merged 1 commit into from Feb 10, 2020

Conversation

@SISheogorath
Copy link
Member

SISheogorath commented Feb 10, 2020

The revision view had a bug that clicking on a list entry would redirect
the user back to the index page instead of providing the revision diff.

This was cased by the baseurl which is now used as reference for hrefs.
Therefore when clicking on the href="#" this was actually pointing at
<baseurl># which is usually the index page.

This patch simply removes the href from the list items and therefore the
link functionality. This fixes the whole problem by removing 9
characters from our source code

The revision view had a bug that clicking on a list entry would redirect
the user back to the index page instead of providing the revision diff.

This was cased by the baseurl which is now used as reference for hrefs.
Therefore when clicking on the `href="#"` this was actually pointing at
`<baseurl>#` which is usually the index page.

This patch simply removes the href from the list items and therefore the
link functionality. This fixes the whole problem by removing 9
characters from our source code.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>
@SISheogorath SISheogorath added the bug label Feb 10, 2020
@SISheogorath SISheogorath added this to the Release 1.6.0 milestone Feb 10, 2020
@SISheogorath SISheogorath merged commit ea2ab05 into codimd:master Feb 10, 2020
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
DCO DCO
Details
WIP Ready for review
Details
security/snyk - package.json (codimd) No manifest changes detected
@SISheogorath SISheogorath deleted the SISheogorath:fix/revisionLinks branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.