Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unix socket not removed on shutdown #50

Merged
merged 2 commits into from Apr 16, 2019

Conversation

Projects
None yet
2 participants
@naimo
Copy link
Contributor

commented Apr 16, 2019

Signed-off-by: naimo nicolas@aimon.fr

@SISheogorath

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Nice to see you contribution!

Can you update your sources to the latest master before merging? git pull --rebase github.com:codimd/server.git master

Also can you please check that npm test passes on your machine? (To modify your commit please use git commit --amend)

When this is done. please push your changes again using git push --force-with-lease=f7ad179177b64618c0598312fc3d4373a3adfbb8 in order to update this pull request :)

@SISheogorath SISheogorath added the bug label Apr 16, 2019

@naimo naimo force-pushed the naimo:master branch from 77c7357 to accb735 Apr 16, 2019

@naimo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Ah just saw your comment, working on it thanks

naimo added some commits Apr 16, 2019

naimo
fix unix socket not removed on shutdown
Signed-off-by: naimo <nicolas@aimon.fr>
naimo
fix trailing space
Signed-off-by: naimo <nicolas@aimon.fr>

@naimo naimo force-pushed the naimo:master branch from accb735 to ed2402d Apr 16, 2019

@SISheogorath SISheogorath added this to the Release 1.4.0 milestone Apr 16, 2019

@SISheogorath SISheogorath merged commit cc53d5e into codimd:master Apr 16, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.