Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint warnings #97

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@SISheogorath
Copy link
Member

commented May 30, 2019

Since we are about to release it's time to finally fix our linting. This
patch basically runs eslint --fix and does some further manual fixes.
Also it sets up eslint to fail on every warning on order to make
warnings visable in the CI process.

There should no functional change be introduced.

Fix eslint warnings
Since we are about to release it's time to finally fix our linting. This
patch basically runs eslint --fix and does some further manual fixes.
Also it sets up eslint to fail on every warning on order to make
warnings visable in the CI process.

There should no functional change be introduced.

Signed-off-by: Sheogorath <sheogorath@shivering-isles.com>

@SISheogorath SISheogorath added this to the Release 1.4.0 milestone May 30, 2019

@SISheogorath SISheogorath requested a review from ccoenen May 30, 2019

@ccoenen

This comment has been minimized.

Copy link
Member

commented May 30, 2019

I'm not comfortable sneaking this in a few hours before a release. This touches a ton of files, even if 95% of it is just white space. I did review it, and it "looks" ok, but I have no way of knowing if I didn't miss something.

@ccoenen

This comment has been minimized.

Copy link
Member

commented May 30, 2019

The diff without white spaces actually is not that long. "it's probably fine". Still, not a big fan of last-minute large patch.

@SISheogorath

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

After shower I thought the same. Let's make it one of the first patches for 1.4.1 :)

@SISheogorath SISheogorath merged commit 6462968 into codimd:master Jun 4, 2019

4 checks passed

DCO DCO
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (codimd) No new issues
Details

@SISheogorath SISheogorath deleted the SISheogorath:fix/linting branch Jun 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.