Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show marked answers in BottomSheet in Quiz #262

Merged
merged 1 commit into from Jun 9, 2019

Conversation

Projects
None yet
2 participants
@adityastic
Copy link
Contributor

commented Jun 5, 2019

Fixes #146

Changes:

  • bottom sheet in quiz fragment reflects the questions with chosen answers

Screenshots for the change:
https://drive.google.com/open?id=1-B0PPVyk5uPuTCq2DnUb0mYXCX0Ezq0x

@auto-label auto-label bot added the feature label Jun 5, 2019

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@aggarwalpulkit596

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

This is for the submitted quiz?

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@aggarwalpulkit596 not yet, It currently only marks the questions answered. In case of submitted quiz, All the answered questions will be marked and not the right answered questions. So you want to show the correct and not correct answers when submitted right?

@adityastic adityastic force-pushed the adityastic:patch-146 branch from 12ca828 to 944d5b3 Jun 5, 2019

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2019

@aggarwalpulkit596 I've updated the pr. It now shows the correct answers rather than the marked answers when the quiz is in submitted state. Uploaded a video for the same :) :
https://drive.google.com/open?id=1-B0PPVyk5uPuTCq2DnUb0mYXCX0Ezq0x

@adityastic adityastic force-pushed the adityastic:patch-146 branch from 944d5b3 to 31453ac Jun 6, 2019

@aggarwalpulkit596

This comment has been minimized.

Copy link
Collaborator

commented Jun 7, 2019

You've handled both the cases ? Submitted quiz as well as draft quiz ?

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

@aggarwalpulkit596 yes please check the video. I've shown both as well

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

@aggarwalpulkit596 do I need to update anything in this?

@aggarwalpulkit596 aggarwalpulkit596 merged commit 989a8d0 into coding-blocks:development Jun 9, 2019

2 of 3 checks passed

codebeat 0 issues resolved and 1 introduced
Details
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@aggarwalpulkit596

This comment has been minimized.

Copy link
Collaborator

commented Jun 9, 2019

Nicely Done @adityastic 🎉

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 9, 2019

@aggarwalpulkit596 all thanks to you 😊

@adityastic adityastic deleted the adityastic:patch-146 branch Jun 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.