Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null pointer exception in pdf activity #316

Merged
merged 1 commit into from Jul 1, 2019

Conversation

Projects
None yet
2 participants
@adityastic
Copy link
Contributor

commented Jun 30, 2019

Fixes #311

Changes:

  • destroy the fragment and adapter first, then move on to destroying the activity

@auto-label auto-label bot added the fix label Jun 30, 2019

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

@aggarwalpulkit596 have a look

@adityastic adityastic force-pushed the adityastic:patch-311 branch from fc202c6 to f85aa95 Jun 30, 2019

@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jun 30, 2019

@aggarwalpulkit596 almost every api test failed. Please check

@aggarwalpulkit596 aggarwalpulkit596 merged commit e0785d8 into coding-blocks:development Jul 1, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Hound No violations found. Woof!
codebeat no reportable quality changes
Details
@adityastic

This comment has been minimized.

Copy link
Contributor Author

commented Jul 1, 2019

@aggarwalpulkit596 great, claimed the bounty for this pr. Review the rest plz

@adityastic adityastic referenced this pull request Jul 1, 2019

Closed

Crash In HomeActivity #319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.