Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Navbar on scroll #514

Merged
merged 9 commits into from Aug 5, 2018

Conversation

Projects
None yet
3 participants
@architkshk
Copy link
Contributor

commented Jun 29, 2018

Fixes #513

architkshk added some commits Jun 29, 2018

@codingblocks-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 29, 2018

Deploy preview for cb-netlify-prod ready!

Built with commit 4987cdc

https://deploy-preview-514--cb-netlify-prod.netlify.com

architkshk and others added some commits Jun 29, 2018

@witty123

This comment has been minimized.

Copy link
Contributor

commented Jul 6, 2018

When I scroll up after scrolling down, the page abruptly goes to the top. Instead we want to make the navbar sticky.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 7, 2018

ezgif com-optimize
@witty123 works fine for me.

@witty123

This comment has been minimized.

Copy link
Contributor

commented Jul 7, 2018

ezgif com-optimize

My bad I was a little unclear, open the navbar and then try to scroll.

@witty123

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2018

@architkshk any updates ?

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2018

will do it today.

architkshk added some commits Jul 28, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2018

@witty123 Done!

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

@witty123 pls review this too

@witty123

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2018

@architkshk not able to scroll expanded navbar

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 5, 2018

@witty123 witty123 merged commit 849c890 into coding-blocks:master Aug 5, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details

@architkshk architkshk deleted the architkshk:nav branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.