Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <div> wrapper from <button> #413

Open
vdvibhu20 opened this issue May 23, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@vdvibhu20
Copy link
Collaborator

commented May 23, 2019

There are two primitive button class types used in our platform:-
.button-solid & .button-dashed

In some files, <button> elements are wrapped inside <div>. Remove the <div> wrapper and apply all the classes and actions to <button> respectively.

For instance, you will find in /app/pods/components/otp-enroll/template.hbs::line22

<div class="button-solid" {{action 'handleClick'}}>
  <button>{{buttonText}}</button>
</div>

After refactoring it should look like
<button class="button-solid" {{action 'handleClick'}}>{{buttonText}}</button>

@vdvibhu20 vdvibhu20 changed the title Remove `<div>` wrapper from `<button>` Remove <div> wrapper from <button> May 23, 2019

@farhan787 farhan787 referenced a pull request that will close this issue May 23, 2019

Open

div wrapper removed from button #414

@sahilbhosale63

This comment has been minimized.

Copy link

commented May 28, 2019

Hi, I am working on this issue.

@farhan787

This comment has been minimized.

Copy link

commented May 29, 2019

@abhishek97 please review :-)

@Anant016

This comment has been minimized.

Copy link

commented Jun 12, 2019

I will send a pull request by today.

@Anant016 Anant016 referenced a pull request that will close this issue Jun 12, 2019

Open

FIXED #413 Remove <div> wrapper from <button> #439

@Anant016

This comment has been minimized.

Copy link

commented Jun 12, 2019

There are two primitive button class types used in our platform:-
.button-solid & .button-dashed

In some files, <button> elements are wrapped inside <div>. Remove the <div> wrapper and apply all the classes and actions to <button> respectively.

For instance, you will find in /app/pods/components/otp-enroll/template.hbs::line22

<div class="button-solid" {{action 'handleClick'}}>
  <button>{{buttonText}}</button>
</div>

After refactoring it should look like
<button class="button-solid" {{action 'handleClick'}}>{{buttonText}}</button>

Sir, it's done in each and every file accordingly, Please check.

@Anant016

This comment has been minimized.

Copy link

commented Jun 18, 2019

Would you please acknowledge the work, and merge my pull request.

farhan787 added a commit to farhan787/codingblocks.online.projectx that referenced this issue Jun 28, 2019

farhan787 added a commit to farhan787/codingblocks.online.projectx that referenced this issue Jul 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.