Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Feedback Modal #253

Merged
merged 10 commits into from Aug 27, 2018

Conversation

Projects
None yet
3 participants
@firefinchdev
Copy link
Contributor

commented Aug 13, 2018

No description provided.

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

@witty123
@abhishek97
Pls Review
Solves #253 .

@firefinchdev firefinchdev referenced this pull request Aug 13, 2018

Closed

Feedback integration #251

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

Motley changes
coding-blocks/motley#270

@abhishek97

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

Why you copied the rating-component? why can't it be reused here?

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

Ok, will update it to single component.

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

@abhishek97
Refactored to one component.
Pls review.

@firefinchdev firefinchdev force-pushed the firefinchdev:feedback-modal branch from 86ae321 to ec17a13 Aug 14, 2018

@witty123

This comment has been minimized.

Copy link
Contributor

commented Aug 17, 2018

@firefinchdev once the user has submitted his feedback, he should be able to edit it.

@firefinchdev firefinchdev force-pushed the firefinchdev:feedback-modal branch from 7c10470 to 5450390 Aug 18, 2018

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

@witty123
Done.
Pls Review.

@witty123

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2018

On hold. Motley has issues with this build. Don't merge.

firefinchdev added some commits Aug 18, 2018

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

screenshot from 2018-08-19 03-11-01
screenshot from 2018-08-19 03-11-03
Works perfectly on latest motley pull with coding-blocks/motley#270

firefinchdev added some commits Aug 22, 2018

Fix
}
})
this.afterFeedback()
return true

This comment has been minimized.

Copy link
@abhishek97

abhishek97 Aug 27, 2018

Member

remove this

@firefinchdev firefinchdev force-pushed the firefinchdev:feedback-modal branch from 404082f to 1affd8f Aug 27, 2018

@abhishek97 abhishek97 merged commit 8e9e6e4 into coding-blocks:master Aug 27, 2018

1 check passed

deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.