Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner feature #412

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
3 participants
@nileshpatra
Copy link

commented May 18, 2019

fixes #350 , I have made the changes asked in my previous PR(#408) on the same issue.

nileshpatra added some commits May 15, 2019

@CajetanRodrigues
Copy link

left a comment

Yes, this seems to be perfect now

@abhishek97

This comment has been minimized.

Copy link
Member

commented May 20, 2019

app/pods/courses/index/ext_images/spinner.gif is not where you put static images. all static assets go inside public folder

@abhishek97

This comment has been minimized.

Copy link
Member

commented May 20, 2019

We already have a loader component.
Let's use that

@nileshpatra

This comment has been minimized.

Copy link
Author

commented May 20, 2019

@abhishek97 , did the change . Here's a screenshot :
Screenshot from 2019-05-20 21-09-57

@abhishek97 abhishek97 closed this May 26, 2019

@nileshpatra

This comment has been minimized.

Copy link
Author

commented May 26, 2019

@abhishek97 may I know as to why is it closed?😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.