Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed <div> wrapper from <button> #438

Open
wants to merge 7 commits into
base: master
from

Conversation

@muskankhedia
Copy link

commented Jun 10, 2019

Fixes: #413

Removed the div wrapper from the button tags in the files.

@muskankhedia

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

@vdvibhu20 Pls review the PR. The changes are made according to the latest code available up to the date.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jun 14, 2019

file app/pods/components/code-editor/template.hbs: still has div wrapper and many other files

@muskankhedia

This comment has been minimized.

Copy link
Author

commented Jun 14, 2019

@vdvibhu20, I have made the changes, pls do have a look.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jun 28, 2019

remove conflicts and sync your branch with coding-blocks:master.

@muskankhedia

This comment has been minimized.

Copy link
Author

commented Aug 4, 2019

@vdvibhu20 pls review the PR, I have solved the merge conflicts.

@muskankhedia

This comment has been minimized.

Copy link
Author

commented Aug 10, 2019

@championswimmer Pls review this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.