Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove <div> wrapper from <button> #449

Open
wants to merge 1 commit into
base: master
from

Conversation

@samagragupta
Copy link

commented Jul 18, 2019

fixes #413

@samagragupta

This comment has been minimized.

Copy link
Author

commented Jul 18, 2019

@vdvibhu20 Please review.

@samagragupta

This comment has been minimized.

Copy link
Author

commented Jul 19, 2019

@championswimmer @abhishek97 please review.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2019

@samagragupta There are still many files which are not refactored.

@samagragupta

This comment has been minimized.

Copy link
Author

commented Jul 23, 2019

@vdvibhu20 Can you please name few of them. I could not found them.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jul 24, 2019

one of them:-
app/pods/attempt/content/quiz/attempt/done/template.hbs:

@samagragupta

This comment has been minimized.

Copy link
Author

commented Jul 24, 2019

@vdvibhu20 There is no <button> tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.