Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ui improvements #221

Closed
wants to merge 19 commits into from

Conversation

Projects
None yet
3 participants
@architkshk
Copy link
Contributor

commented Jul 7, 2018

architkshk added some commits Jul 7, 2018

@architkshk architkshk referenced this pull request Jul 7, 2018

Closed

Ui issue on mobile #258

@@ -7,7 +7,7 @@
overflow: auto;
background: white;
box-shadow: 0px 14px 41px 0 rgba(51, 51, 51, 0.1);
z-index: 300;
z-index:190;

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 7, 2018

Collaborator

Since dropdown is used at multiple pages, try changing z-index of menu instead of dropdown.
Also don't make changes in element layer as it will break things on other pages.

@@ -58,4 +58,9 @@
font-size: $font-xs;
font-weight: $font-medium;
}
.grey {

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 7, 2018

Collaborator

no need of using .grey class.
Requirement: Overwrite button element in sass/styles/elements/html to remove padding

architkshk added some commits Jul 11, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2018

@witty123

This comment has been minimized.

Copy link
Collaborator

commented Jul 11, 2018

@architkshk add screenshots for different screen sizes please

architkshk added some commits Jul 12, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2018

  1. sidebar-user pic
    screenshot from 2018-07-12 14-19-16
  2. App Page- No overlap and no extra padding on button
    screenshot from 2018-07-12 14-25-26
    screenshot from 2018-07-12 14-25-39
    screenshot from 2018-07-12 14-25-42
  3. Profile Page- College Name and top button
    screenshot from 2018-07-12 14-27-12
    screenshot from 2018-07-12 14-27-38
  4. Other- Buttons and headings
    screenshot from 2018-07-12 14-38-24
    screenshot from 2018-07-12 14-38-52
    screenshot from 2018-07-12 14-40-19
@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 13, 2018

@witty123 Please review.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jul 14, 2018

@architkshk We are refactoring motley for accounts.codingblocks.com. You will have to update your PR according those changes. I will notify you once the refactoring is done.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Jul 23, 2018

@architkshk we have refactored motley for accounts.codingblocks.com you can now update your PR accordingly.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2018

@vdvibhu20 done

margin-bottom: 20px;
@include padding-mixin(0px, 30px, 0px, 0);
margin-bottom: 0;
line-height: 40px;
font-size: $font-xs;

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 24, 2018

Collaborator

use padding-bottom instead of line height

@include padding-mixin(0, 160px, 33px, 0);
@include margin(0, 0, 30px, 0);
@include padding-mixin(0, 160px, 0px, 0);
line-height: 3rem;

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 24, 2018

Collaborator

use padding-bottom instead of line-height

display: inline-block;
max-width: 8rem;
word-wrap: break-word;
}

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 24, 2018

Collaborator

align text right inside this.
also add grey color using $navLink

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 24, 2018

Collaborator

Shift this thing from media query to object layer as things might break on bigger screen sizes.

architkshk added some commits Jul 24, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2018

@vdvibhu20 Done!

max-width: 50%;
word-wrap: break-word;
text-align: right;
color: $navLink;

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 25, 2018

Collaborator

This breaks for app-page
screen shot 2018-07-25 at 1 34 17 pm

This comment has been minimized.

Copy link
@vdvibhu20

vdvibhu20 Jul 25, 2018

Collaborator

replacing .faded on app page with .grey will fix it.

This comment has been minimized.

Copy link
@architkshk

architkshk Jul 25, 2018

Author Contributor

Done!

architkshk added some commits Jul 25, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 7, 2018

@vdvibhu20 any updates?

@witty123

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2018

@architkshk can you resolve the conflicts please

architkshk added some commits Aug 15, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

@witty123 Done!

@vdvibhu20 vdvibhu20 closed this Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.