Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDE mobile view #277

Open
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@architkshk
Copy link
Contributor

commented Aug 13, 2018

@abhishek97 Please review.
screenshot from 2018-08-13 19-18-39
This is first PR with first commit.

architkshk added some commits Aug 13, 2018

@abhishek97

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

@architkshk We want all the tabs. Problem, Leaderboard, and Submissions here.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

screenshot from 2018-08-13 23-33-08

@abhishek97 it shows all 3
the earlier screenshot was scrolled down.

@abhishek97

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

Sorry, my bad. Also, post a screenshot for submissions and leaderboard tab.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

@abhishek97 i think motley does not have dummy data for those tabs.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

@abhishek97
made changes usnig inspect
screenshot from 2018-08-14 00-30-04
screenshot from 2018-08-14 00-49-46

@abhishek97

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

@architkshk That's smart. Can you do the same submissions? it's markup is already there in motley.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 13, 2018

@@ -478,7 +271,212 @@
</div>
</div>
</div>
<div class="section collapse">

This comment has been minimized.

Copy link
@abhishek97

abhishek97 Aug 14, 2018

Member

why you moved the code here?
Can it be done without it?

This comment has been minimized.

Copy link
@architkshk

architkshk Aug 14, 2018

Author Contributor

@abhishek97 It can be done but it would require some changes as it shows table of content above actual content. Also, the same structure is being followed in timeline.hbs and online courses site.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2018

@abhishek97 It can be done but it would require some changes as it shows table of content above actual content. Also, the same structure is being followed in timeline.hbs and online courses site.

@witty123

This comment has been minimized.

Copy link
Collaborator

commented Aug 14, 2018

@architkshk resolve conflicts please

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

@witty123 Done!!
Pls review

@abhishek97

This comment has been minimized.

Copy link
Member

commented Aug 15, 2018

@architkshk Can you make a PR on projectx, making DOM change required as you have done here?
I'm skeptical to merge this due to too much markup changes which might not be trivial to do in projectx.

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2018

@abhishek97
projectx doesn't req DOM markup changes. it is already same as i did.
screenshot from 2018-08-15 22-41-12

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

@abhishek97 @witty123 Please merge this if evrything looks fine.

@vdvibhu20

This comment has been minimized.

Copy link
Collaborator

commented Aug 20, 2018

screen shot 2018-08-20 at 5 19 39 pm

@architkshk Code editor result and language selector still visible on submissions page.

architkshk added some commits Aug 20, 2018

@architkshk

This comment has been minimized.

Copy link
Contributor Author

commented Aug 20, 2018

@vdvibhu20 the problem was due to motley refactor. Now resolved pls check.

@samagragupta

This comment has been minimized.

Copy link

commented May 15, 2019

What is the status?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.