Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predictions submit on website even after time passes #660

Closed
mriganksingh1 opened this issue Jul 4, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@mriganksingh1
Copy link

commented Jul 4, 2019

Describe the bug
ICC World Cup Predictions, we can make predictions even after submitting period is over.

Expected behavior
We should not be able to make predictions after predictions period is over by any way or any means.

Logs
In this, I have just changed my laptop time to 7:00 a.m after the match is over and i am able to make predictions.
WhatsApp Image 2019-06-28 at 23 07 52
BOSS

@abhishek97

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Hi,
Yes the frontend UI shows incorrect state when you change time. However, you won't be able to submit prediction as there is a backend check in place to check this.
Since this doesn't affect integrity of the system and doesn't affect most genuine users, this is taken as a low priority bug. Feel free to send in a PR with a fix ☺️

@mriganksingh1

This comment has been minimized.

Copy link
Author

commented Jul 5, 2019

Contrarily i was able to submit predictions and also got free credits

@mriganksingh1

This comment has been minimized.

Copy link
Author

commented Jul 5, 2019

I have reported this only after trying please check.

@mriganksingh1

This comment has been minimized.

Copy link
Author

commented Jul 5, 2019

Ok now i see the check is placed but it was not there before when i have tried last time

@abhishek97 abhishek97 added the wontfix label Jul 8, 2019

@abhishek97 abhishek97 closed this Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.