Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event subscription #358

Closed
wants to merge 26 commits into from

Conversation

Projects
None yet
5 participants
@firefinchdev
Copy link
Contributor

commented Aug 15, 2018

No description provided.

@firefinchdev firefinchdev force-pushed the firefinchdev:event-src branch 2 times, most recently from 7e1a2ac to 4184e49 Aug 16, 2018

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2018

@championswimmer Pls merge #353 . This PR depends on it.

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2018

@championswimmer
I have completed this PR, but it requires rebase and merging, which can be done after #353 is merged.
Pls review #353 and this PR.

@firefinchdev firefinchdev changed the title WIP: Implement event subscription Implement event subscription Aug 16, 2018

}

eventSubscription.forEach (event => {
if (event.model === 'user') {

This comment has been minimized.

Copy link
@championswimmer

championswimmer Aug 17, 2018

Member

why not switch cases ?

This comment has been minimized.

Copy link
@firefinchdev

firefinchdev Aug 18, 2018

Author Contributor

Done

firefinchdev and others added some commits Aug 15, 2018

Refactored, improved error handling (#292)
* error handling

* controller
X_X

@firefinchdev firefinchdev force-pushed the firefinchdev:event-src branch from 57dde8f to 4b8b358 Aug 18, 2018

@codecov

This comment has been minimized.

Copy link

commented Aug 18, 2018

Codecov Report

Merging #358 into master will increase coverage by 10%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #358    +/-   ##
======================================
+ Coverage      90%   100%   +10%     
======================================
  Files           2      2            
  Lines          10     15     +5     
======================================
+ Hits            9     15     +6     
+ Misses          1      0     -1
Impacted Files Coverage Δ
tests/utils/test-random-generator.js 100% <0%> (ø) ⬆️
src/utils/generator.js 100% <0%> (+25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a31987...77b2244. Read the comment docs.

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 18, 2018

@championswimmer
Changes done.
Pls review.

}).then(parsedBody => {
console.log(parsedBody)
}).catch(err => {
console.error('webhookPOST', err)

This comment has been minimized.

Copy link
@championswimmer

championswimmer Aug 22, 2018

Member

put this into Raven please

This comment has been minimized.

Copy link
@firefinchdev

firefinchdev Aug 23, 2018

Author Contributor

Done.

userId: userId
})
})
.catch(e => console.error('eventUserCreate', e))

This comment has been minimized.

Copy link
@championswimmer

championswimmer Aug 22, 2018

Member

all the errors should be Raven.captureException()

This comment has been minimized.

Copy link
@firefinchdev

firefinchdev Aug 23, 2018

Author Contributor

Done.

firefinchdev added some commits Aug 23, 2018

@firefinchdev

This comment has been minimized.

Copy link
Contributor Author

commented Aug 23, 2018

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.