Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] allow deleting clients #675

Merged
merged 5 commits into from Aug 17, 2019

Conversation

@imdhruvgupta
Copy link
Contributor

commented Jul 21, 2019

Developed Feature discussed in #674 .

@codecov

This comment has been minimized.

Copy link

commented Jul 21, 2019

Codecov Report

Merging #675 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #675   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          15     15           
=====================================
  Hits           15     15

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4c4aa9...6e6824e. Read the comment docs.

@TdevM
Copy link
Collaborator

left a comment

Show alert before deleting a client.

imdhruvgupta added some commits Aug 5, 2019

@TdevM

TdevM approved these changes Aug 7, 2019

@championswimmer championswimmer merged commit 4fc69f4 into coding-blocks:master Aug 17, 2019

8 of 9 checks passed

Sider 1 issue left; visit Sider to review the issues.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ci/circleci: test Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing f4c4aa9...6e6824e
Details
codecov/project 100% remains the same compared to f4c4aa9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - package.json (championswimmer) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.