Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement APIs for URLs #98

Merged
merged 2 commits into from Jun 8, 2019

Conversation

Projects
None yet
2 participants
@Manit1
Copy link
Contributor

commented May 21, 2019

Fixes #96

@jatinkatyal13

This comment has been minimized.

Copy link
Collaborator

commented May 29, 2019

@Manit1 Back merge the branch and include the AuthToken authentication that you implemented!

@Manit1 Manit1 force-pushed the Manit1:ft-1 branch from 3eca7d7 to ec5aaf2 May 29, 2019

)
if (!url) {
throw new Error('Error creating shortlink. Try again')
}

This comment has been minimized.

Copy link
@jatinkatyal13

jatinkatyal13 May 29, 2019

Collaborator

I guess you forgot to send a response. 😄

try {
const group = await findGroupByPrefix(req.params.group)
if (!group) {
throw new Error('URL Group prefix not found. Wrong URL possibly.')

This comment has been minimized.

Copy link
@jatinkatyal13

jatinkatyal13 May 29, 2019

Collaborator

Errors should be raised from the controller.

@Manit1

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@jatinkatyal13 Done! 🚀 🎸

@jatinkatyal13 jatinkatyal13 merged commit 0053a17 into coding-blocks:master Jun 8, 2019

1 check passed

Sider No issues found!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.