feat: plural rule improvement #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #672
Resolves Issue
The specific issue as well as a discussion on how it could be solved is given in #672.
The issue basically is that there are languages where
Intl.PluralRulesdoes not always resolves toother, but it resolves tomanyin cases whereotherwould be expected by the current implementation. This causes the plural to resolve to an empty string. This PR fixes the issue by setting an appropriate fallback.Some tests for Polish were added that illustrate the problem and that would fail without the fixed introduced in this PR.
PS: Sorry for the very delayed PR 😆