Resolve #240 -- Add support for Django's tasks framework (>6.0) #241
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
===========================================
- Coverage 100.00% 99.42% -0.58%
===========================================
Files 13 13
Lines 495 518 +23
===========================================
+ Hits 495 515 +20
- Misses 0 3 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
codingjoe
force-pushed
the
issues/240/tasks
branch
from
d1d0ca9 to
1667138
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds support for Django 6.0's native task framework to handle async image processing. The implementation provides fallback options for existing Celery, Dramatiq, and Django RQ integrations with pending deprecation warnings for Django 6.0+.
Key changes:
- Added Django Tasks backend integration as the default processor for Django 6.0+
- Renamed existing processor functions and added deprecation warnings for legacy task runners
- Updated documentation to guide users on configuring Django Tasks
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
Show a summary per file
| File | Description |
|---|---|
| pictures/tasks.py | Adds Django Tasks integration with @task decorator, renames legacy processor functions, and adds deprecation warnings for Django 6.0+ |
| pictures/conf.py | Adds BACKEND configuration option for Django Tasks backend selection |
| tests/test_tasks.py | Adds test case for Django Tasks misconfiguration validation |
| tests/testapp/settings.py | Adds Django Tasks configuration for test environment |
| README.md | Updates documentation to describe Django Tasks setup and deprecation of legacy integrations |
| pyproject.toml | Updates supported Django versions, removes 5.1 and adds 6.0 |
| .github/workflows/ci.yml | Adds Django 6.0 to CI test matrix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Django's task framework provides native unified framework to interact with any 3rd party task runner, like Celery, Dramatiq or RQ. This step will allow us to greatly redurece the complexity of this package once Django 5.2 LTS reaches EoL. Starting with Django 6.0 we are default to the new task framework while providing fallblack options with pending deprecation warnings.
codingjoe
force-pushed
the
issues/240/tasks
branch
from
1667138 to
2538a37
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 12 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
amureki
left a comment
amureki
left a comment
There was a problem hiding this comment.
Looks solid, however I did not have a chance to test this on actual Django 6.0 yet.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Django's task framework provides native unified framework to
interact with any 3rd party task runner, like Celery, Dramatiq or
RQ. This step will allow us to greatly redurece the complexity of
this package once Django 5.2 LTS reaches EoL.
Starting with Django 6.0 we are default to the new task framework
while providing fallblack options with pending deprecation warnings.